Browse Source

Disable all typographic replacements in markdown renderer (#11871)

* Disable all typographic replacements in markdown renderer

Previously we only disabled some of them. This disables all the default
replacements that goldmark's typographer extension offers, matching
GitHub's renderer.

Ref: https://github.com/yuin/goldmark#typographer-extension
Fixes: https://github.com/go-gitea/gitea/issues/11001

* remove typographer extension completely

* fix test

* really fix test

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
tags/v1.13.0-rc1
silverwind 4 years ago
parent
commit
2447ffc74a
No account linked to committer's email address
2 changed files with 1 additions and 8 deletions
  1. 1
    1
      modules/markup/html_test.go
  2. 0
    7
      modules/markup/markdown/markdown.go

+ 1
- 1
modules/markup/html_test.go View File

@@ -208,7 +208,7 @@ func TestRender_email(t *testing.T) {
// Test that should *not* be turned into email links
test(
"\"info@gitea.com\"",
`<p>“info@gitea.com”</p>`)
`<p>&#34;info@gitea.com&#34;</p>`)
test(
"/home/gitea/mailstore/info@gitea/com",
`<p>/home/gitea/mailstore/info@gitea/com</p>`)

+ 0
- 7
modules/markup/markdown/markdown.go View File

@@ -49,13 +49,6 @@ func render(body []byte, urlPrefix string, metas map[string]string, wikiMarkdown
extension.TaskList,
extension.DefinitionList,
common.FootnoteExtension,
extension.NewTypographer(
extension.WithTypographicSubstitutions(extension.TypographicSubstitutions{
extension.EnDash: nil,
extension.EmDash: nil,
extension.Ellipsis: nil,
}),
),
meta.Meta,
),
goldmark.WithParserOptions(

Loading…
Cancel
Save