Browse Source

Ignore `runs-on` with expressions when warning no matched runners (#25917)

Fix #25905

Co-authored-by: Giteabot <teabot@gitea.io>
tags/v1.21.0-rc0
Jason Song 10 months ago
parent
commit
29e959fd00
No account linked to committer's email address
1 changed files with 7 additions and 0 deletions
  1. 7
    0
      routers/web/repo/actions/actions.go

+ 7
- 0
routers/web/repo/actions/actions.go View File

@@ -7,6 +7,7 @@ import (
"bytes"
"fmt"
"net/http"
"strings"

actions_model "code.gitea.io/gitea/models/actions"
"code.gitea.io/gitea/models/db"
@@ -106,6 +107,12 @@ func List(ctx *context.Context) {
for _, j := range wf.Jobs {
runsOnList := j.RunsOn()
for _, ro := range runsOnList {
if strings.Contains(ro, "${{") {
// Skip if it contains expressions.
// The expressions could be very complex and could not be evaluated here,
// so just skip it, it's OK since it's just a tooltip message.
continue
}
if !allRunnerLabels.Contains(ro) {
workflow.ErrMsg = ctx.Locale.Tr("actions.runs.no_matching_runner_helper", ro)
break

Loading…
Cancel
Save