Browse Source

Improve LFS error logs (#24072) (#24082)

Backport #24072 by @wxiaoguang

The error logs were not clear.

Help (but not fix) #24053

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
tags/v1.19.1
Giteabot 1 year ago
parent
commit
93c7611c32
No account linked to committer's email address
1 changed files with 3 additions and 2 deletions
  1. 3
    2
      services/lfs/server.go

+ 3
- 2
services/lfs/server.go View File

@@ -126,7 +126,6 @@ func DownloadHandler(ctx *context.Context) {
_, err = content.Seek(fromByte, io.SeekStart)
if err != nil {
log.Error("Whilst trying to read LFS OID[%s]: Unable to seek to %d Error: %v", meta.Oid, fromByte, err)

writeStatus(ctx, http.StatusInternalServerError)
return
}
@@ -334,10 +333,11 @@ func UploadHandler(ctx *context.Context) {
log.Error("Upload does not match LFS MetaObject [%s]. Error: %v", p.Oid, err)
writeStatusMessage(ctx, http.StatusUnprocessableEntity, err.Error())
} else {
log.Error("Error whilst uploadOrVerify LFS OID[%s]: %v", p.Oid, err)
writeStatus(ctx, http.StatusInternalServerError)
}
if _, err = git_model.RemoveLFSMetaObjectByOid(ctx, repository.ID, p.Oid); err != nil {
log.Error("Error whilst removing metaobject for LFS OID[%s]: %v", p.Oid, err)
log.Error("Error whilst removing MetaObject for LFS OID[%s]: %v", p.Oid, err)
}
return
}
@@ -365,6 +365,7 @@ func VerifyHandler(ctx *context.Context) {

status := http.StatusOK
if err != nil {
log.Error("Error whilst verifying LFS OID[%s]: %v", p.Oid, err)
status = http.StatusInternalServerError
} else if !ok {
status = http.StatusNotFound

Loading…
Cancel
Save