Browse Source

Always delete existing scheduled action tasks (#27662) (#27688)

Backport #27662 by @KN4CK3R

Fixes #27650

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
tags/v1.21.0-rc2
Giteabot 7 months ago
parent
commit
9b14f1a8ed
No account linked to committer's email address
1 changed files with 8 additions and 11 deletions
  1. 8
    11
      services/actions/notifier_helper.go

+ 8
- 11
services/actions/notifier_helper.go View File

@@ -374,11 +374,6 @@ func handleSchedules(
commit *git.Commit,
input *notifyInput,
) error {
if len(detectedWorkflows) == 0 {
log.Trace("repo %s with commit %s couldn't find schedules", input.Repo.RepoPath(), commit.ID)
return nil
}

branch, err := commit.GetBranchName()
if err != nil {
return err
@@ -388,18 +383,20 @@ func handleSchedules(
return nil
}

rows, _, err := actions_model.FindSchedules(ctx, actions_model.FindScheduleOptions{RepoID: input.Repo.ID})
if err != nil {
log.Error("FindCrons: %v", err)
if count, err := actions_model.CountSchedules(ctx, actions_model.FindScheduleOptions{RepoID: input.Repo.ID}); err != nil {
log.Error("CountSchedules: %v", err)
return err
}

if len(rows) > 0 {
} else if count > 0 {
if err := actions_model.DeleteScheduleTaskByRepo(ctx, input.Repo.ID); err != nil {
log.Error("DeleteCronTaskByRepo: %v", err)
}
}

if len(detectedWorkflows) == 0 {
log.Trace("repo %s with commit %s couldn't find schedules", input.Repo.RepoPath(), commit.ID)
return nil
}

p, err := json.Marshal(input.Payload)
if err != nil {
return fmt.Errorf("json.Marshal: %w", err)

Loading…
Cancel
Save