Browse Source

Reduce some allocations in type conversion (#26772)

tags/v1.21.0-rc0
Chongyi Zheng 9 months ago
parent
commit
ac2f8c9ac6
No account linked to committer's email address
3 changed files with 4 additions and 4 deletions
  1. 1
    1
      modules/log/event_writer_base.go
  2. 1
    1
      services/packages/rpm/repository.go
  3. 2
    2
      services/pull/pull.go

+ 1
- 1
modules/log/event_writer_base.go View File

@@ -90,7 +90,7 @@ func (b *EventWriterBaseImpl) Run(ctx context.Context) {

if exprRegexp != nil {
fileLineCaller := fmt.Sprintf("%s:%d:%s", event.Origin.Filename, event.Origin.Line, event.Origin.Caller)
matched := exprRegexp.Match([]byte(fileLineCaller)) || exprRegexp.Match([]byte(event.Origin.MsgSimpleText))
matched := exprRegexp.MatchString(fileLineCaller) || exprRegexp.MatchString(event.Origin.MsgSimpleText)
if !matched {
continue
}

+ 1
- 1
services/packages/rpm/repository.go View File

@@ -232,7 +232,7 @@ func buildRepomd(pv *packages_model.PackageVersion, ownerID int64, data []*repoD
}

var buf bytes.Buffer
buf.Write([]byte(xml.Header))
buf.WriteString(xml.Header)
if err := xml.NewEncoder(&buf).Encode(&Repomd{
Xmlns: "http://linux.duke.edu/metadata/repo",
XmlnsRpm: "http://linux.duke.edu/metadata/rpm",

+ 2
- 2
services/pull/pull.go View File

@@ -755,11 +755,11 @@ func GetSquashMergeCommitMessages(ctx context.Context, pr *issues_model.PullRequ
}

for _, author := range authors {
if _, err := stringBuilder.Write([]byte("Co-authored-by: ")); err != nil {
if _, err := stringBuilder.WriteString("Co-authored-by: "); err != nil {
log.Error("Unable to write to string builder Error: %v", err)
return ""
}
if _, err := stringBuilder.Write([]byte(author)); err != nil {
if _, err := stringBuilder.WriteString(author); err != nil {
log.Error("Unable to write to string builder Error: %v", err)
return ""
}

Loading…
Cancel
Save