Browse Source

Remove jQuery `.attr` from the Fomantic modal cancel buttons (#30113)

- Switched from jQuery `attr` to plain javascript `setAttribute`
- Tested the modals and they work as before

---------

Co-authored-by: silverwind <me@silverwind.io>
tags/v1.22.0-rc0
Yarden Shoham 2 months ago
parent
commit
f47e00d9d3
No account linked to committer's email address
1 changed files with 3 additions and 1 deletions
  1. 3
    1
      web_src/js/modules/fomantic/modal.js

+ 3
- 1
web_src/js/modules/fomantic/modal.js View File

@@ -19,7 +19,9 @@ function ariaModalFn(...args) {
// In such case, the "Enter" key will trigger the "cancel" button instead of "ok" button, then the dialog will be closed.
// It breaks the user experience - the "Enter" key should confirm the dialog and submit the form.
// So, all "cancel" buttons without "[type]" must be marked as "type=button".
$(el).find('form button.cancel:not([type])').attr('type', 'button');
for (const button of el.querySelectorAll('form button.cancel:not([type])')) {
button.setAttribute('type', 'button');
}
}
}
return ret;

Loading…
Cancel
Save