You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

review.go 29KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058
  1. // Copyright 2018 The Gitea Authors. All rights reserved.
  2. // SPDX-License-Identifier: MIT
  3. package issues
  4. import (
  5. "context"
  6. "fmt"
  7. "slices"
  8. "strings"
  9. "code.gitea.io/gitea/models/db"
  10. git_model "code.gitea.io/gitea/models/git"
  11. "code.gitea.io/gitea/models/organization"
  12. "code.gitea.io/gitea/models/perm"
  13. access_model "code.gitea.io/gitea/models/perm/access"
  14. "code.gitea.io/gitea/models/unit"
  15. user_model "code.gitea.io/gitea/models/user"
  16. "code.gitea.io/gitea/modules/structs"
  17. "code.gitea.io/gitea/modules/timeutil"
  18. "code.gitea.io/gitea/modules/util"
  19. "xorm.io/builder"
  20. )
  21. // ErrReviewNotExist represents a "ReviewNotExist" kind of error.
  22. type ErrReviewNotExist struct {
  23. ID int64
  24. }
  25. // IsErrReviewNotExist checks if an error is a ErrReviewNotExist.
  26. func IsErrReviewNotExist(err error) bool {
  27. _, ok := err.(ErrReviewNotExist)
  28. return ok
  29. }
  30. func (err ErrReviewNotExist) Error() string {
  31. return fmt.Sprintf("review does not exist [id: %d]", err.ID)
  32. }
  33. func (err ErrReviewNotExist) Unwrap() error {
  34. return util.ErrNotExist
  35. }
  36. // ErrNotValidReviewRequest an not allowed review request modify
  37. type ErrNotValidReviewRequest struct {
  38. Reason string
  39. UserID int64
  40. RepoID int64
  41. }
  42. // IsErrNotValidReviewRequest checks if an error is a ErrNotValidReviewRequest.
  43. func IsErrNotValidReviewRequest(err error) bool {
  44. _, ok := err.(ErrNotValidReviewRequest)
  45. return ok
  46. }
  47. func (err ErrNotValidReviewRequest) Error() string {
  48. return fmt.Sprintf("%s [user_id: %d, repo_id: %d]",
  49. err.Reason,
  50. err.UserID,
  51. err.RepoID)
  52. }
  53. func (err ErrNotValidReviewRequest) Unwrap() error {
  54. return util.ErrInvalidArgument
  55. }
  56. // ErrReviewRequestOnClosedPR represents an error when an user tries to request a re-review on a closed or merged PR.
  57. type ErrReviewRequestOnClosedPR struct{}
  58. // IsErrReviewRequestOnClosedPR checks if an error is an ErrReviewRequestOnClosedPR.
  59. func IsErrReviewRequestOnClosedPR(err error) bool {
  60. _, ok := err.(ErrReviewRequestOnClosedPR)
  61. return ok
  62. }
  63. func (err ErrReviewRequestOnClosedPR) Error() string {
  64. return "cannot request a re-review on a closed or merged PR"
  65. }
  66. func (err ErrReviewRequestOnClosedPR) Unwrap() error {
  67. return util.ErrPermissionDenied
  68. }
  69. // ReviewType defines the sort of feedback a review gives
  70. type ReviewType int
  71. // ReviewTypeUnknown unknown review type
  72. const ReviewTypeUnknown ReviewType = -1
  73. const (
  74. // ReviewTypePending is a review which is not published yet
  75. ReviewTypePending ReviewType = iota
  76. // ReviewTypeApprove approves changes
  77. ReviewTypeApprove
  78. // ReviewTypeComment gives general feedback
  79. ReviewTypeComment
  80. // ReviewTypeReject gives feedback blocking merge
  81. ReviewTypeReject
  82. // ReviewTypeRequest request review from others
  83. ReviewTypeRequest
  84. )
  85. // Icon returns the corresponding icon for the review type
  86. func (rt ReviewType) Icon() string {
  87. switch rt {
  88. case ReviewTypeApprove:
  89. return "check"
  90. case ReviewTypeReject:
  91. return "diff"
  92. case ReviewTypeComment:
  93. return "comment"
  94. case ReviewTypeRequest:
  95. return "dot-fill"
  96. default:
  97. return "comment"
  98. }
  99. }
  100. // Review represents collection of code comments giving feedback for a PR
  101. type Review struct {
  102. ID int64 `xorm:"pk autoincr"`
  103. Type ReviewType
  104. Reviewer *user_model.User `xorm:"-"`
  105. ReviewerID int64 `xorm:"index"`
  106. ReviewerTeamID int64 `xorm:"NOT NULL DEFAULT 0"`
  107. ReviewerTeam *organization.Team `xorm:"-"`
  108. OriginalAuthor string
  109. OriginalAuthorID int64
  110. Issue *Issue `xorm:"-"`
  111. IssueID int64 `xorm:"index"`
  112. Content string `xorm:"TEXT"`
  113. // Official is a review made by an assigned approver (counts towards approval)
  114. Official bool `xorm:"NOT NULL DEFAULT false"`
  115. CommitID string `xorm:"VARCHAR(64)"`
  116. Stale bool `xorm:"NOT NULL DEFAULT false"`
  117. Dismissed bool `xorm:"NOT NULL DEFAULT false"`
  118. CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
  119. UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
  120. // CodeComments are the initial code comments of the review
  121. CodeComments CodeComments `xorm:"-"`
  122. Comments []*Comment `xorm:"-"`
  123. }
  124. func init() {
  125. db.RegisterModel(new(Review))
  126. }
  127. // LoadCodeComments loads CodeComments
  128. func (r *Review) LoadCodeComments(ctx context.Context) (err error) {
  129. if r.CodeComments != nil {
  130. return err
  131. }
  132. if err = r.loadIssue(ctx); err != nil {
  133. return err
  134. }
  135. r.CodeComments, err = fetchCodeCommentsByReview(ctx, r.Issue, nil, r, false)
  136. return err
  137. }
  138. func (r *Review) loadIssue(ctx context.Context) (err error) {
  139. if r.Issue != nil {
  140. return err
  141. }
  142. r.Issue, err = GetIssueByID(ctx, r.IssueID)
  143. return err
  144. }
  145. // LoadReviewer loads reviewer
  146. func (r *Review) LoadReviewer(ctx context.Context) (err error) {
  147. if r.ReviewerID == 0 || r.Reviewer != nil {
  148. return err
  149. }
  150. r.Reviewer, err = user_model.GetPossibleUserByID(ctx, r.ReviewerID)
  151. if err != nil {
  152. if !user_model.IsErrUserNotExist(err) {
  153. return fmt.Errorf("GetPossibleUserByID [%d]: %w", r.ReviewerID, err)
  154. }
  155. r.ReviewerID = user_model.GhostUserID
  156. r.Reviewer = user_model.NewGhostUser()
  157. return nil
  158. }
  159. return err
  160. }
  161. // LoadReviewerTeam loads reviewer team
  162. func (r *Review) LoadReviewerTeam(ctx context.Context) (err error) {
  163. if r.ReviewerTeamID == 0 || r.ReviewerTeam != nil {
  164. return nil
  165. }
  166. r.ReviewerTeam, err = organization.GetTeamByID(ctx, r.ReviewerTeamID)
  167. return err
  168. }
  169. // LoadAttributes loads all attributes except CodeComments
  170. func (r *Review) LoadAttributes(ctx context.Context) (err error) {
  171. if err = r.loadIssue(ctx); err != nil {
  172. return err
  173. }
  174. if err = r.LoadCodeComments(ctx); err != nil {
  175. return err
  176. }
  177. if err = r.LoadReviewer(ctx); err != nil {
  178. return err
  179. }
  180. if err = r.LoadReviewerTeam(ctx); err != nil {
  181. return err
  182. }
  183. return err
  184. }
  185. func (r *Review) HTMLTypeColorName() string {
  186. switch r.Type {
  187. case ReviewTypeApprove:
  188. if r.Stale {
  189. return "yellow"
  190. }
  191. return "green"
  192. case ReviewTypeComment:
  193. return "grey"
  194. case ReviewTypeReject:
  195. return "red"
  196. case ReviewTypeRequest:
  197. return "yellow"
  198. }
  199. return "grey"
  200. }
  201. // GetReviewByID returns the review by the given ID
  202. func GetReviewByID(ctx context.Context, id int64) (*Review, error) {
  203. review := new(Review)
  204. if has, err := db.GetEngine(ctx).ID(id).Get(review); err != nil {
  205. return nil, err
  206. } else if !has {
  207. return nil, ErrReviewNotExist{ID: id}
  208. }
  209. return review, nil
  210. }
  211. // CreateReviewOptions represent the options to create a review. Type, Issue and Reviewer are required.
  212. type CreateReviewOptions struct {
  213. Content string
  214. Type ReviewType
  215. Issue *Issue
  216. Reviewer *user_model.User
  217. ReviewerTeam *organization.Team
  218. Official bool
  219. CommitID string
  220. Stale bool
  221. }
  222. // IsOfficialReviewer check if at least one of the provided reviewers can make official reviews in issue (counts towards required approvals)
  223. func IsOfficialReviewer(ctx context.Context, issue *Issue, reviewer *user_model.User) (bool, error) {
  224. if err := issue.LoadPullRequest(ctx); err != nil {
  225. return false, err
  226. }
  227. pr := issue.PullRequest
  228. rule, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  229. if err != nil {
  230. return false, err
  231. }
  232. if rule == nil {
  233. // if no rule is found, then user with write access can make official reviews
  234. err := pr.LoadBaseRepo(ctx)
  235. if err != nil {
  236. return false, err
  237. }
  238. writeAccess, err := access_model.HasAccessUnit(ctx, reviewer, pr.BaseRepo, unit.TypeCode, perm.AccessModeWrite)
  239. if err != nil {
  240. return false, err
  241. }
  242. return writeAccess, nil
  243. }
  244. official, err := git_model.IsUserOfficialReviewer(ctx, rule, reviewer)
  245. if official || err != nil {
  246. return official, err
  247. }
  248. return false, nil
  249. }
  250. // IsOfficialReviewerTeam check if reviewer in this team can make official reviews in issue (counts towards required approvals)
  251. func IsOfficialReviewerTeam(ctx context.Context, issue *Issue, team *organization.Team) (bool, error) {
  252. if err := issue.LoadPullRequest(ctx); err != nil {
  253. return false, err
  254. }
  255. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, issue.PullRequest.BaseRepoID, issue.PullRequest.BaseBranch)
  256. if err != nil {
  257. return false, err
  258. }
  259. if pb == nil {
  260. return false, nil
  261. }
  262. if !pb.EnableApprovalsWhitelist {
  263. return team.UnitAccessMode(ctx, unit.TypeCode) >= perm.AccessModeWrite, nil
  264. }
  265. return slices.Contains(pb.ApprovalsWhitelistTeamIDs, team.ID), nil
  266. }
  267. // CreateReview creates a new review based on opts
  268. func CreateReview(ctx context.Context, opts CreateReviewOptions) (*Review, error) {
  269. ctx, committer, err := db.TxContext(ctx)
  270. if err != nil {
  271. return nil, err
  272. }
  273. defer committer.Close()
  274. sess := db.GetEngine(ctx)
  275. review := &Review{
  276. Issue: opts.Issue,
  277. IssueID: opts.Issue.ID,
  278. Reviewer: opts.Reviewer,
  279. ReviewerTeam: opts.ReviewerTeam,
  280. Content: opts.Content,
  281. Official: opts.Official,
  282. CommitID: opts.CommitID,
  283. Stale: opts.Stale,
  284. }
  285. if opts.Reviewer != nil {
  286. review.Type = opts.Type
  287. review.ReviewerID = opts.Reviewer.ID
  288. reviewCond := builder.Eq{"reviewer_id": opts.Reviewer.ID, "issue_id": opts.Issue.ID}
  289. // make sure user review requests are cleared
  290. if opts.Type != ReviewTypePending {
  291. if _, err := sess.Where(reviewCond.And(builder.Eq{"type": ReviewTypeRequest})).Delete(new(Review)); err != nil {
  292. return nil, err
  293. }
  294. }
  295. // make sure if the created review gets dismissed no old review surface
  296. // other types can be ignored, as they don't affect branch protection
  297. if opts.Type == ReviewTypeApprove || opts.Type == ReviewTypeReject {
  298. if _, err := sess.Where(reviewCond.And(builder.In("type", ReviewTypeApprove, ReviewTypeReject))).
  299. Cols("dismissed").Update(&Review{Dismissed: true}); err != nil {
  300. return nil, err
  301. }
  302. }
  303. } else if opts.ReviewerTeam != nil {
  304. review.Type = ReviewTypeRequest
  305. review.ReviewerTeamID = opts.ReviewerTeam.ID
  306. } else {
  307. return nil, fmt.Errorf("provide either reviewer or reviewer team")
  308. }
  309. if _, err := sess.Insert(review); err != nil {
  310. return nil, err
  311. }
  312. return review, committer.Commit()
  313. }
  314. // GetCurrentReview returns the current pending review of reviewer for given issue
  315. func GetCurrentReview(ctx context.Context, reviewer *user_model.User, issue *Issue) (*Review, error) {
  316. if reviewer == nil {
  317. return nil, nil
  318. }
  319. reviews, err := FindReviews(ctx, FindReviewOptions{
  320. Type: ReviewTypePending,
  321. IssueID: issue.ID,
  322. ReviewerID: reviewer.ID,
  323. })
  324. if err != nil {
  325. return nil, err
  326. }
  327. if len(reviews) == 0 {
  328. return nil, ErrReviewNotExist{}
  329. }
  330. reviews[0].Reviewer = reviewer
  331. reviews[0].Issue = issue
  332. return reviews[0], nil
  333. }
  334. // ReviewExists returns whether a review exists for a particular line of code in the PR
  335. func ReviewExists(ctx context.Context, issue *Issue, treePath string, line int64) (bool, error) {
  336. return db.GetEngine(ctx).Cols("id").Exist(&Comment{IssueID: issue.ID, TreePath: treePath, Line: line, Type: CommentTypeCode})
  337. }
  338. // ContentEmptyErr represents an content empty error
  339. type ContentEmptyErr struct{}
  340. func (ContentEmptyErr) Error() string {
  341. return "Review content is empty"
  342. }
  343. // IsContentEmptyErr returns true if err is a ContentEmptyErr
  344. func IsContentEmptyErr(err error) bool {
  345. _, ok := err.(ContentEmptyErr)
  346. return ok
  347. }
  348. // SubmitReview creates a review out of the existing pending review or creates a new one if no pending review exist
  349. func SubmitReview(ctx context.Context, doer *user_model.User, issue *Issue, reviewType ReviewType, content, commitID string, stale bool, attachmentUUIDs []string) (*Review, *Comment, error) {
  350. ctx, committer, err := db.TxContext(ctx)
  351. if err != nil {
  352. return nil, nil, err
  353. }
  354. defer committer.Close()
  355. sess := db.GetEngine(ctx)
  356. official := false
  357. review, err := GetCurrentReview(ctx, doer, issue)
  358. if err != nil {
  359. if !IsErrReviewNotExist(err) {
  360. return nil, nil, err
  361. }
  362. if reviewType != ReviewTypeApprove && len(strings.TrimSpace(content)) == 0 {
  363. return nil, nil, ContentEmptyErr{}
  364. }
  365. if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
  366. // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
  367. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
  368. return nil, nil, err
  369. }
  370. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  371. return nil, nil, err
  372. }
  373. }
  374. // No current review. Create a new one!
  375. if review, err = CreateReview(ctx, CreateReviewOptions{
  376. Type: reviewType,
  377. Issue: issue,
  378. Reviewer: doer,
  379. Content: content,
  380. Official: official,
  381. CommitID: commitID,
  382. Stale: stale,
  383. }); err != nil {
  384. return nil, nil, err
  385. }
  386. } else {
  387. if err := review.LoadCodeComments(ctx); err != nil {
  388. return nil, nil, err
  389. }
  390. if reviewType != ReviewTypeApprove && len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
  391. return nil, nil, ContentEmptyErr{}
  392. }
  393. if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
  394. // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
  395. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
  396. return nil, nil, err
  397. }
  398. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  399. return nil, nil, err
  400. }
  401. }
  402. review.Official = official
  403. review.Issue = issue
  404. review.Content = content
  405. review.Type = reviewType
  406. review.CommitID = commitID
  407. review.Stale = stale
  408. if _, err := sess.ID(review.ID).Cols("content, type, official, commit_id, stale").Update(review); err != nil {
  409. return nil, nil, err
  410. }
  411. }
  412. comm, err := CreateComment(ctx, &CreateCommentOptions{
  413. Type: CommentTypeReview,
  414. Doer: doer,
  415. Content: review.Content,
  416. Issue: issue,
  417. Repo: issue.Repo,
  418. ReviewID: review.ID,
  419. Attachments: attachmentUUIDs,
  420. })
  421. if err != nil || comm == nil {
  422. return nil, nil, err
  423. }
  424. // try to remove team review request if need
  425. if issue.Repo.Owner.IsOrganization() && (reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject) {
  426. teamReviewRequests := make([]*Review, 0, 10)
  427. if err := sess.SQL("SELECT * FROM review WHERE issue_id = ? AND reviewer_team_id > 0 AND type = ?", issue.ID, ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
  428. return nil, nil, err
  429. }
  430. for _, teamReviewRequest := range teamReviewRequests {
  431. ok, err := organization.IsTeamMember(ctx, issue.Repo.OwnerID, teamReviewRequest.ReviewerTeamID, doer.ID)
  432. if err != nil {
  433. return nil, nil, err
  434. } else if !ok {
  435. continue
  436. }
  437. if _, err := db.DeleteByID[Review](ctx, teamReviewRequest.ID); err != nil {
  438. return nil, nil, err
  439. }
  440. }
  441. }
  442. comm.Review = review
  443. return review, comm, committer.Commit()
  444. }
  445. // GetReviewByIssueIDAndUserID get the latest review of reviewer for a pull request
  446. func GetReviewByIssueIDAndUserID(ctx context.Context, issueID, userID int64) (*Review, error) {
  447. review := new(Review)
  448. has, err := db.GetEngine(ctx).Where(
  449. builder.In("type", ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest).
  450. And(builder.Eq{"issue_id": issueID, "reviewer_id": userID, "original_author_id": 0})).
  451. Desc("id").
  452. Get(review)
  453. if err != nil {
  454. return nil, err
  455. }
  456. if !has {
  457. return nil, ErrReviewNotExist{}
  458. }
  459. return review, nil
  460. }
  461. // GetTeamReviewerByIssueIDAndTeamID get the latest review request of reviewer team for a pull request
  462. func GetTeamReviewerByIssueIDAndTeamID(ctx context.Context, issueID, teamID int64) (*Review, error) {
  463. review := new(Review)
  464. has, err := db.GetEngine(ctx).Where(builder.Eq{"issue_id": issueID, "reviewer_team_id": teamID}).
  465. Desc("id").
  466. Get(review)
  467. if err != nil {
  468. return nil, err
  469. }
  470. if !has {
  471. return nil, ErrReviewNotExist{0}
  472. }
  473. return review, err
  474. }
  475. // MarkReviewsAsStale marks existing reviews as stale
  476. func MarkReviewsAsStale(ctx context.Context, issueID int64) (err error) {
  477. _, err = db.GetEngine(ctx).Exec("UPDATE `review` SET stale=? WHERE issue_id=?", true, issueID)
  478. return err
  479. }
  480. // MarkReviewsAsNotStale marks existing reviews as not stale for a giving commit SHA
  481. func MarkReviewsAsNotStale(ctx context.Context, issueID int64, commitID string) (err error) {
  482. _, err = db.GetEngine(ctx).Exec("UPDATE `review` SET stale=? WHERE issue_id=? AND commit_id=?", false, issueID, commitID)
  483. return err
  484. }
  485. // DismissReview change the dismiss status of a review
  486. func DismissReview(ctx context.Context, review *Review, isDismiss bool) (err error) {
  487. if review.Dismissed == isDismiss || (review.Type != ReviewTypeApprove && review.Type != ReviewTypeReject) {
  488. return nil
  489. }
  490. review.Dismissed = isDismiss
  491. if review.ID == 0 {
  492. return ErrReviewNotExist{}
  493. }
  494. _, err = db.GetEngine(ctx).ID(review.ID).Cols("dismissed").Update(review)
  495. return err
  496. }
  497. // InsertReviews inserts review and review comments
  498. func InsertReviews(ctx context.Context, reviews []*Review) error {
  499. ctx, committer, err := db.TxContext(ctx)
  500. if err != nil {
  501. return err
  502. }
  503. defer committer.Close()
  504. sess := db.GetEngine(ctx)
  505. for _, review := range reviews {
  506. if _, err := sess.NoAutoTime().Insert(review); err != nil {
  507. return err
  508. }
  509. if _, err := sess.NoAutoTime().Insert(&Comment{
  510. Type: CommentTypeReview,
  511. Content: review.Content,
  512. PosterID: review.ReviewerID,
  513. OriginalAuthor: review.OriginalAuthor,
  514. OriginalAuthorID: review.OriginalAuthorID,
  515. IssueID: review.IssueID,
  516. ReviewID: review.ID,
  517. CreatedUnix: review.CreatedUnix,
  518. UpdatedUnix: review.UpdatedUnix,
  519. }); err != nil {
  520. return err
  521. }
  522. for _, c := range review.Comments {
  523. c.ReviewID = review.ID
  524. }
  525. if len(review.Comments) > 0 {
  526. if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
  527. return err
  528. }
  529. }
  530. }
  531. return committer.Commit()
  532. }
  533. // AddReviewRequest add a review request from one reviewer
  534. func AddReviewRequest(ctx context.Context, issue *Issue, reviewer, doer *user_model.User) (*Comment, error) {
  535. ctx, committer, err := db.TxContext(ctx)
  536. if err != nil {
  537. return nil, err
  538. }
  539. defer committer.Close()
  540. sess := db.GetEngine(ctx)
  541. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, reviewer.ID)
  542. if err != nil && !IsErrReviewNotExist(err) {
  543. return nil, err
  544. }
  545. if review != nil {
  546. // skip it when reviewer hase been request to review
  547. if review.Type == ReviewTypeRequest {
  548. return nil, committer.Commit() // still commit the transaction, or committer.Close() will rollback it, even if it's a reused transaction.
  549. }
  550. if issue.IsClosed {
  551. return nil, ErrReviewRequestOnClosedPR{}
  552. }
  553. if issue.IsPull {
  554. if err := issue.LoadPullRequest(ctx); err != nil {
  555. return nil, err
  556. }
  557. if issue.PullRequest.HasMerged {
  558. return nil, ErrReviewRequestOnClosedPR{}
  559. }
  560. }
  561. }
  562. // if the reviewer is an official reviewer,
  563. // remove the official flag in the all previous reviews
  564. official, err := IsOfficialReviewer(ctx, issue, reviewer)
  565. if err != nil {
  566. return nil, err
  567. } else if official {
  568. if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, reviewer.ID); err != nil {
  569. return nil, err
  570. }
  571. }
  572. review, err = CreateReview(ctx, CreateReviewOptions{
  573. Type: ReviewTypeRequest,
  574. Issue: issue,
  575. Reviewer: reviewer,
  576. Official: official,
  577. Stale: false,
  578. })
  579. if err != nil {
  580. return nil, err
  581. }
  582. comment, err := CreateComment(ctx, &CreateCommentOptions{
  583. Type: CommentTypeReviewRequest,
  584. Doer: doer,
  585. Repo: issue.Repo,
  586. Issue: issue,
  587. RemovedAssignee: false, // Use RemovedAssignee as !isRequest
  588. AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
  589. ReviewID: review.ID,
  590. })
  591. if err != nil {
  592. return nil, err
  593. }
  594. // func caller use the created comment to retrieve created review too.
  595. comment.Review = review
  596. return comment, committer.Commit()
  597. }
  598. // RemoveReviewRequest remove a review request from one reviewer
  599. func RemoveReviewRequest(ctx context.Context, issue *Issue, reviewer, doer *user_model.User) (*Comment, error) {
  600. ctx, committer, err := db.TxContext(ctx)
  601. if err != nil {
  602. return nil, err
  603. }
  604. defer committer.Close()
  605. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, reviewer.ID)
  606. if err != nil && !IsErrReviewNotExist(err) {
  607. return nil, err
  608. }
  609. if review == nil || review.Type != ReviewTypeRequest {
  610. return nil, nil
  611. }
  612. if _, err = db.DeleteByBean(ctx, review); err != nil {
  613. return nil, err
  614. }
  615. official, err := IsOfficialReviewer(ctx, issue, reviewer)
  616. if err != nil {
  617. return nil, err
  618. } else if official {
  619. if err := restoreLatestOfficialReview(ctx, issue.ID, reviewer.ID); err != nil {
  620. return nil, err
  621. }
  622. }
  623. comment, err := CreateComment(ctx, &CreateCommentOptions{
  624. Type: CommentTypeReviewRequest,
  625. Doer: doer,
  626. Repo: issue.Repo,
  627. Issue: issue,
  628. RemovedAssignee: true, // Use RemovedAssignee as !isRequest
  629. AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
  630. })
  631. if err != nil {
  632. return nil, err
  633. }
  634. return comment, committer.Commit()
  635. }
  636. // Recalculate the latest official review for reviewer
  637. func restoreLatestOfficialReview(ctx context.Context, issueID, reviewerID int64) error {
  638. review, err := GetReviewByIssueIDAndUserID(ctx, issueID, reviewerID)
  639. if err != nil && !IsErrReviewNotExist(err) {
  640. return err
  641. }
  642. if review != nil {
  643. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
  644. return err
  645. }
  646. }
  647. return nil
  648. }
  649. // AddTeamReviewRequest add a review request from one team
  650. func AddTeamReviewRequest(ctx context.Context, issue *Issue, reviewer *organization.Team, doer *user_model.User) (*Comment, error) {
  651. ctx, committer, err := db.TxContext(ctx)
  652. if err != nil {
  653. return nil, err
  654. }
  655. defer committer.Close()
  656. review, err := GetTeamReviewerByIssueIDAndTeamID(ctx, issue.ID, reviewer.ID)
  657. if err != nil && !IsErrReviewNotExist(err) {
  658. return nil, err
  659. }
  660. // This team already has been requested to review - therefore skip this.
  661. if review != nil {
  662. return nil, nil
  663. }
  664. official, err := IsOfficialReviewerTeam(ctx, issue, reviewer)
  665. if err != nil {
  666. return nil, fmt.Errorf("isOfficialReviewerTeam(): %w", err)
  667. } else if !official {
  668. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  669. return nil, fmt.Errorf("isOfficialReviewer(): %w", err)
  670. }
  671. }
  672. if review, err = CreateReview(ctx, CreateReviewOptions{
  673. Type: ReviewTypeRequest,
  674. Issue: issue,
  675. ReviewerTeam: reviewer,
  676. Official: official,
  677. Stale: false,
  678. }); err != nil {
  679. return nil, err
  680. }
  681. if official {
  682. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_team_id=?", false, issue.ID, reviewer.ID); err != nil {
  683. return nil, err
  684. }
  685. }
  686. comment, err := CreateComment(ctx, &CreateCommentOptions{
  687. Type: CommentTypeReviewRequest,
  688. Doer: doer,
  689. Repo: issue.Repo,
  690. Issue: issue,
  691. RemovedAssignee: false, // Use RemovedAssignee as !isRequest
  692. AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
  693. ReviewID: review.ID,
  694. })
  695. if err != nil {
  696. return nil, fmt.Errorf("CreateComment(): %w", err)
  697. }
  698. return comment, committer.Commit()
  699. }
  700. // RemoveTeamReviewRequest remove a review request from one team
  701. func RemoveTeamReviewRequest(ctx context.Context, issue *Issue, reviewer *organization.Team, doer *user_model.User) (*Comment, error) {
  702. ctx, committer, err := db.TxContext(ctx)
  703. if err != nil {
  704. return nil, err
  705. }
  706. defer committer.Close()
  707. review, err := GetTeamReviewerByIssueIDAndTeamID(ctx, issue.ID, reviewer.ID)
  708. if err != nil && !IsErrReviewNotExist(err) {
  709. return nil, err
  710. }
  711. if review == nil {
  712. return nil, nil
  713. }
  714. if _, err = db.DeleteByBean(ctx, review); err != nil {
  715. return nil, err
  716. }
  717. official, err := IsOfficialReviewerTeam(ctx, issue, reviewer)
  718. if err != nil {
  719. return nil, fmt.Errorf("isOfficialReviewerTeam(): %w", err)
  720. }
  721. if official {
  722. // recalculate which is the latest official review from that team
  723. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, -reviewer.ID)
  724. if err != nil && !IsErrReviewNotExist(err) {
  725. return nil, err
  726. }
  727. if review != nil {
  728. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
  729. return nil, err
  730. }
  731. }
  732. }
  733. if doer == nil {
  734. return nil, committer.Commit()
  735. }
  736. comment, err := CreateComment(ctx, &CreateCommentOptions{
  737. Type: CommentTypeReviewRequest,
  738. Doer: doer,
  739. Repo: issue.Repo,
  740. Issue: issue,
  741. RemovedAssignee: true, // Use RemovedAssignee as !isRequest
  742. AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
  743. })
  744. if err != nil {
  745. return nil, fmt.Errorf("CreateComment(): %w", err)
  746. }
  747. return comment, committer.Commit()
  748. }
  749. // MarkConversation Add or remove Conversation mark for a code comment
  750. func MarkConversation(ctx context.Context, comment *Comment, doer *user_model.User, isResolve bool) (err error) {
  751. if comment.Type != CommentTypeCode {
  752. return nil
  753. }
  754. if isResolve {
  755. if comment.ResolveDoerID != 0 {
  756. return nil
  757. }
  758. if _, err = db.GetEngine(ctx).Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", doer.ID, comment.ID); err != nil {
  759. return err
  760. }
  761. } else {
  762. if comment.ResolveDoerID == 0 {
  763. return nil
  764. }
  765. if _, err = db.GetEngine(ctx).Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", 0, comment.ID); err != nil {
  766. return err
  767. }
  768. }
  769. return nil
  770. }
  771. // CanMarkConversation Add or remove Conversation mark for a code comment permission check
  772. // the PR writer , offfcial reviewer and poster can do it
  773. func CanMarkConversation(ctx context.Context, issue *Issue, doer *user_model.User) (permResult bool, err error) {
  774. if doer == nil || issue == nil {
  775. return false, fmt.Errorf("issue or doer is nil")
  776. }
  777. if doer.ID != issue.PosterID {
  778. if err = issue.LoadRepo(ctx); err != nil {
  779. return false, err
  780. }
  781. p, err := access_model.GetUserRepoPermission(ctx, issue.Repo, doer)
  782. if err != nil {
  783. return false, err
  784. }
  785. permResult = p.CanAccess(perm.AccessModeWrite, unit.TypePullRequests)
  786. if !permResult {
  787. if permResult, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  788. return false, err
  789. }
  790. }
  791. if !permResult {
  792. return false, nil
  793. }
  794. }
  795. return true, nil
  796. }
  797. // DeleteReview delete a review and it's code comments
  798. func DeleteReview(ctx context.Context, r *Review) error {
  799. ctx, committer, err := db.TxContext(ctx)
  800. if err != nil {
  801. return err
  802. }
  803. defer committer.Close()
  804. if r.ID == 0 {
  805. return fmt.Errorf("review is not allowed to be 0")
  806. }
  807. if r.Type == ReviewTypeRequest {
  808. return fmt.Errorf("review request can not be deleted using this method")
  809. }
  810. opts := FindCommentsOptions{
  811. Type: CommentTypeCode,
  812. IssueID: r.IssueID,
  813. ReviewID: r.ID,
  814. }
  815. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  816. return err
  817. }
  818. opts = FindCommentsOptions{
  819. Type: CommentTypeReview,
  820. IssueID: r.IssueID,
  821. ReviewID: r.ID,
  822. }
  823. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  824. return err
  825. }
  826. opts = FindCommentsOptions{
  827. Type: CommentTypeDismissReview,
  828. IssueID: r.IssueID,
  829. ReviewID: r.ID,
  830. }
  831. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  832. return err
  833. }
  834. if _, err := db.DeleteByID[Review](ctx, r.ID); err != nil {
  835. return err
  836. }
  837. if r.Official {
  838. if err := restoreLatestOfficialReview(ctx, r.IssueID, r.ReviewerID); err != nil {
  839. return err
  840. }
  841. }
  842. return committer.Commit()
  843. }
  844. // GetCodeCommentsCount return count of CodeComments a Review has
  845. func (r *Review) GetCodeCommentsCount(ctx context.Context) int {
  846. opts := FindCommentsOptions{
  847. Type: CommentTypeCode,
  848. IssueID: r.IssueID,
  849. ReviewID: r.ID,
  850. }
  851. conds := opts.ToConds()
  852. if r.ID == 0 {
  853. conds = conds.And(builder.Eq{"invalidated": false})
  854. }
  855. count, err := db.GetEngine(ctx).Where(conds).Count(new(Comment))
  856. if err != nil {
  857. return 0
  858. }
  859. return int(count)
  860. }
  861. // HTMLURL formats a URL-string to the related review issue-comment
  862. func (r *Review) HTMLURL(ctx context.Context) string {
  863. opts := FindCommentsOptions{
  864. Type: CommentTypeReview,
  865. IssueID: r.IssueID,
  866. ReviewID: r.ID,
  867. }
  868. comment := new(Comment)
  869. has, err := db.GetEngine(ctx).Where(opts.ToConds()).Get(comment)
  870. if err != nil || !has {
  871. return ""
  872. }
  873. return comment.HTMLURL(ctx)
  874. }
  875. // RemapExternalUser ExternalUserRemappable interface
  876. func (r *Review) RemapExternalUser(externalName string, externalID, userID int64) error {
  877. r.OriginalAuthor = externalName
  878. r.OriginalAuthorID = externalID
  879. r.ReviewerID = userID
  880. return nil
  881. }
  882. // GetUserID ExternalUserRemappable interface
  883. func (r *Review) GetUserID() int64 { return r.ReviewerID }
  884. // GetExternalName ExternalUserRemappable interface
  885. func (r *Review) GetExternalName() string { return r.OriginalAuthor }
  886. // GetExternalID ExternalUserRemappable interface
  887. func (r *Review) GetExternalID() int64 { return r.OriginalAuthorID }
  888. // UpdateReviewsMigrationsByType updates reviews' migrations information via given git service type and original id and poster id
  889. func UpdateReviewsMigrationsByType(ctx context.Context, tp structs.GitServiceType, originalAuthorID string, posterID int64) error {
  890. _, err := db.GetEngine(ctx).Table("review").
  891. Where("original_author_id = ?", originalAuthorID).
  892. And(migratedIssueCond(tp)).
  893. Update(map[string]any{
  894. "reviewer_id": posterID,
  895. "original_author": "",
  896. "original_author_id": 0,
  897. })
  898. return err
  899. }