123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320 |
- // Copyright 2020 The Gitea Authors. All rights reserved.
- // SPDX-License-Identifier: MIT
-
- package issues_test
-
- import (
- "testing"
-
- "code.gitea.io/gitea/models/db"
- issues_model "code.gitea.io/gitea/models/issues"
- repo_model "code.gitea.io/gitea/models/repo"
- "code.gitea.io/gitea/models/unittest"
- user_model "code.gitea.io/gitea/models/user"
-
- "github.com/stretchr/testify/assert"
- )
-
- func TestGetReviewByID(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- review, err := issues_model.GetReviewByID(db.DefaultContext, 1)
- assert.NoError(t, err)
- assert.Equal(t, "Demo Review", review.Content)
- assert.Equal(t, issues_model.ReviewTypeApprove, review.Type)
-
- _, err = issues_model.GetReviewByID(db.DefaultContext, 23892)
- assert.Error(t, err)
- assert.True(t, issues_model.IsErrReviewNotExist(err), "IsErrReviewNotExist")
- }
-
- func TestReview_LoadAttributes(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- review := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 1})
- assert.NoError(t, review.LoadAttributes(db.DefaultContext))
- assert.NotNil(t, review.Issue)
- assert.NotNil(t, review.Reviewer)
-
- invalidReview1 := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 2})
- assert.Error(t, invalidReview1.LoadAttributes(db.DefaultContext))
-
- invalidReview2 := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 3})
- assert.Error(t, invalidReview2.LoadAttributes(db.DefaultContext))
- }
-
- func TestReview_LoadCodeComments(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- review := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 4})
- assert.NoError(t, review.LoadAttributes(db.DefaultContext))
- assert.NoError(t, review.LoadCodeComments(db.DefaultContext))
- assert.Len(t, review.CodeComments, 1)
- assert.Equal(t, int64(4), review.CodeComments["README.md"][int64(4)][0].Line)
- }
-
- func TestReviewType_Icon(t *testing.T) {
- assert.Equal(t, "check", issues_model.ReviewTypeApprove.Icon())
- assert.Equal(t, "diff", issues_model.ReviewTypeReject.Icon())
- assert.Equal(t, "comment", issues_model.ReviewTypeComment.Icon())
- assert.Equal(t, "comment", issues_model.ReviewTypeUnknown.Icon())
- assert.Equal(t, "dot-fill", issues_model.ReviewTypeRequest.Icon())
- assert.Equal(t, "comment", issues_model.ReviewType(6).Icon())
- }
-
- func TestFindReviews(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- reviews, err := issues_model.FindReviews(db.DefaultContext, issues_model.FindReviewOptions{
- Type: issues_model.ReviewTypeApprove,
- IssueID: 2,
- ReviewerID: 1,
- })
- assert.NoError(t, err)
- assert.Len(t, reviews, 1)
- assert.Equal(t, "Demo Review", reviews[0].Content)
- }
-
- func TestFindLatestReviews(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- reviews, err := issues_model.FindLatestReviews(db.DefaultContext, issues_model.FindReviewOptions{
- Type: issues_model.ReviewTypeApprove,
- IssueID: 11,
- })
- assert.NoError(t, err)
- assert.Len(t, reviews, 2)
- assert.Equal(t, "duplicate review from user5 (latest)", reviews[0].Content)
- assert.Equal(t, "singular review from org6 and final review for this pr", reviews[1].Content)
- }
-
- func TestGetCurrentReview(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-
- review, err := issues_model.GetCurrentReview(db.DefaultContext, user, issue)
- assert.NoError(t, err)
- assert.NotNil(t, review)
- assert.Equal(t, issues_model.ReviewTypePending, review.Type)
- assert.Equal(t, "Pending Review", review.Content)
-
- user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 7})
- review2, err := issues_model.GetCurrentReview(db.DefaultContext, user2, issue)
- assert.Error(t, err)
- assert.True(t, issues_model.IsErrReviewNotExist(err))
- assert.Nil(t, review2)
- }
-
- func TestCreateReview(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-
- review, err := issues_model.CreateReview(db.DefaultContext, issues_model.CreateReviewOptions{
- Content: "New Review",
- Type: issues_model.ReviewTypePending,
- Issue: issue,
- Reviewer: user,
- })
- assert.NoError(t, err)
- assert.Equal(t, "New Review", review.Content)
- unittest.AssertExistsAndLoadBean(t, &issues_model.Review{Content: "New Review"})
- }
-
- func TestGetReviewersByIssueID(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
- user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
- org3 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 3})
- user4 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
-
- expectedReviews := []*issues_model.Review{}
- expectedReviews = append(expectedReviews,
- &issues_model.Review{
- Reviewer: org3,
- Type: issues_model.ReviewTypeReject,
- UpdatedUnix: 946684812,
- },
- &issues_model.Review{
- Reviewer: user4,
- Type: issues_model.ReviewTypeApprove,
- UpdatedUnix: 946684813,
- },
- &issues_model.Review{
- Reviewer: user2,
- Type: issues_model.ReviewTypeReject,
- UpdatedUnix: 946684814,
- })
-
- allReviews, err := issues_model.GetReviewsByIssueID(db.DefaultContext, issue.ID)
- assert.NoError(t, err)
- for _, review := range allReviews {
- assert.NoError(t, review.LoadReviewer(db.DefaultContext))
- }
- if assert.Len(t, allReviews, 3) {
- for i, review := range allReviews {
- assert.Equal(t, expectedReviews[i].Reviewer, review.Reviewer)
- assert.Equal(t, expectedReviews[i].Type, review.Type)
- assert.Equal(t, expectedReviews[i].UpdatedUnix, review.UpdatedUnix)
- }
- }
-
- allReviews, err = issues_model.GetReviewsByIssueID(db.DefaultContext, issue.ID)
- assert.NoError(t, err)
- assert.NoError(t, allReviews.LoadReviewers(db.DefaultContext))
- if assert.Len(t, allReviews, 3) {
- for i, review := range allReviews {
- assert.Equal(t, expectedReviews[i].Reviewer, review.Reviewer)
- assert.Equal(t, expectedReviews[i].Type, review.Type)
- assert.Equal(t, expectedReviews[i].UpdatedUnix, review.UpdatedUnix)
- }
- }
- }
-
- func TestDismissReview(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- rejectReviewExample := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- approveReviewExample := unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 8})
- assert.False(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, rejectReviewExample, true))
- rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- assert.True(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, requestReviewExample, true))
- rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- assert.True(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, requestReviewExample, true))
- rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- assert.True(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, requestReviewExample, false))
- rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- assert.True(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, requestReviewExample, false))
- rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 9})
- requestReviewExample = unittest.AssertExistsAndLoadBean(t, &issues_model.Review{ID: 11})
- assert.True(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, rejectReviewExample, false))
- assert.False(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.False(t, approveReviewExample.Dismissed)
-
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, approveReviewExample, true))
- assert.False(t, rejectReviewExample.Dismissed)
- assert.False(t, requestReviewExample.Dismissed)
- assert.True(t, approveReviewExample.Dismissed)
- }
-
- func TestDeleteReview(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-
- review1, err := issues_model.CreateReview(db.DefaultContext, issues_model.CreateReviewOptions{
- Content: "Official rejection",
- Type: issues_model.ReviewTypeReject,
- Official: false,
- Issue: issue,
- Reviewer: user,
- })
- assert.NoError(t, err)
-
- review2, err := issues_model.CreateReview(db.DefaultContext, issues_model.CreateReviewOptions{
- Content: "Official approval",
- Type: issues_model.ReviewTypeApprove,
- Official: true,
- Issue: issue,
- Reviewer: user,
- })
- assert.NoError(t, err)
-
- assert.NoError(t, issues_model.DeleteReview(db.DefaultContext, review2))
-
- _, err = issues_model.GetReviewByID(db.DefaultContext, review2.ID)
- assert.Error(t, err)
- assert.True(t, issues_model.IsErrReviewNotExist(err), "IsErrReviewNotExist")
-
- review1, err = issues_model.GetReviewByID(db.DefaultContext, review1.ID)
- assert.NoError(t, err)
- assert.True(t, review1.Official)
- }
-
- func TestDeleteDismissedReview(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID})
- review, err := issues_model.CreateReview(db.DefaultContext, issues_model.CreateReviewOptions{
- Content: "reject",
- Type: issues_model.ReviewTypeReject,
- Official: false,
- Issue: issue,
- Reviewer: user,
- })
- assert.NoError(t, err)
- assert.NoError(t, issues_model.DismissReview(db.DefaultContext, review, true))
- comment, err := issues_model.CreateComment(db.DefaultContext, &issues_model.CreateCommentOptions{
- Type: issues_model.CommentTypeDismissReview,
- Doer: user,
- Repo: repo,
- Issue: issue,
- ReviewID: review.ID,
- Content: "dismiss",
- })
- assert.NoError(t, err)
- unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: comment.ID})
- assert.NoError(t, issues_model.DeleteReview(db.DefaultContext, review))
- unittest.AssertNotExistsBean(t, &issues_model.Comment{ID: comment.ID})
- }
-
- func TestAddReviewRequest(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
-
- pull := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 1})
- assert.NoError(t, pull.LoadIssue(db.DefaultContext))
- issue := pull.Issue
- assert.NoError(t, issue.LoadRepo(db.DefaultContext))
- reviewer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
- _, err := issues_model.CreateReview(db.DefaultContext, issues_model.CreateReviewOptions{
- Issue: issue,
- Reviewer: reviewer,
- Type: issues_model.ReviewTypeReject,
- })
-
- assert.NoError(t, err)
- pull.HasMerged = false
- assert.NoError(t, pull.UpdateCols(db.DefaultContext, "has_merged"))
- issue.IsClosed = true
- _, err = issues_model.AddReviewRequest(db.DefaultContext, issue, reviewer, &user_model.User{})
- assert.Error(t, err)
- assert.True(t, issues_model.IsErrReviewRequestOnClosedPR(err))
-
- pull.HasMerged = true
- assert.NoError(t, pull.UpdateCols(db.DefaultContext, "has_merged"))
- issue.IsClosed = false
- _, err = issues_model.AddReviewRequest(db.DefaultContext, issue, reviewer, &user_model.User{})
- assert.Error(t, err)
- assert.True(t, issues_model.IsErrReviewRequestOnClosedPR(err))
- }
|