Mirrors/sonarqube
1
0
Fork 0
mirror of https://github.com/SonarSource/sonarqube.git synced 2024-07-28 20:18:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

SONAR-3404 do not limit search of reviews by default (was 200).

Browse Source
This commit is contained in:
Simon Brandhof 2012-04-11 19:02:11 +02:00
parent b7017a2ddc
commit c8278a1e6b
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sonar-server/src/main/webapp/WEB-INF/app/controllers/api/reviews_controller.rb
View File

@ -40,7 +40,7 @@ class Api::ReviewsController < Api::ApiController
# - 'assignees'
#
def index
reviews=select_authorized(:user, Review.search(params), :project)
reviews=select_authorized(:user, Review.search(params.merge({'limit' => 500})), :project)
render_reviews(reviews, params[:output] == 'HTML')
end

1
sonar-server/src/main/webapp/WEB-INF/app/controllers/reviews_controller.rb
View File

@ -313,6 +313,7 @@ class ReviewsController < ApplicationController
end
options['sort'] = @sort unless @sort.blank?
options['asc'] = @asc
options['limit']=500
found_reviews = Review.search(options)
@reviews = select_authorized(:user, found_reviews, :project)

3
sonar-server/src/main/webapp/WEB-INF/app/models/review.rb
View File

@ -259,6 +259,7 @@ class Review < ActiveRecord::Base
def self.search(options={})
conditions=[]
values={}
no_need_for_db_request = false
if options['id'].present?
conditions << 'id=:id'
@ -392,7 +393,7 @@ class Review < ActiveRecord::Base
end
found_reviews = []
found_reviews = Review.find(:all, :include => ['review_comments', 'project', 'assignee', 'resource', 'user'], :conditions => [conditions.join(' AND '), values], :order => sort, :limit => 200) unless no_need_for_db_request
found_reviews = Review.find(:all, :include => ['review_comments', 'project', 'assignee', 'resource', 'user'], :conditions => [conditions.join(' AND '), values], :order => sort, :limit => options['limit']) unless no_need_for_db_request
found_reviews
end