Pārlūkot izejas kodu

When a Grid gets scroll-locked, cancel the scrollInProgress handler. (#12116)

Otherwise opening a Grid editor can cause ApplicationConnection to get
stuck in 'active' state even if no actual scroll position processing is
ongoing, which in turn causes TestBench delays when it tries to wait
until ApplicationConnection indicates that everything necessary has been
processed.
tags/7.7.23
Anna Koskinen pirms 3 gadiem
vecāks
revīzija
b817d61d6a
Revīzijas autora e-pasta adrese nav piesaistīta nevienam kontam

+ 10
- 3
client/src/main/java/com/vaadin/client/widget/escalator/ScrollbarBundle.java Parādīt failu

@@ -790,9 +790,16 @@ public abstract class ScrollbarBundle implements DeferredWorker {
if (!isLocked()) {
scrollPos = newScrollPos;
scrollEventFirer.scheduleEvent();
} else if (scrollPos != newScrollPos) {
// we need to actually undo the setting of the scroll.
internalSetScrollPos(toInt32(scrollPos));
} else {
if (scrollPos != newScrollPos) {
// we need to actually undo the setting of the scroll.
internalSetScrollPos(toInt32(scrollPos));
}
if (scrollInProgress != null) {
// cancel the in-progress indicator
scrollInProgress.removeHandler();
scrollInProgress = null;
}
}
}


Notiek ielāde…
Atcelt
Saglabāt