]> source.dussan.org Git - gitea.git/commit
Add basic edit ldap auth test & actually fix #16252 (#16465) (#16494) v1.15.0-rc2
authorzeripath <art27@cantab.net>
Thu, 22 Jul 2021 14:24:21 +0000 (15:24 +0100)
committerGitHub <noreply@github.com>
Thu, 22 Jul 2021 14:24:21 +0000 (17:24 +0300)
commit0b06b2019f3b09f44c1cb045b90cd6a0ab649b1b
tree6a716cfb9da7f108051447887bd2f9fd6124e305
parent057205a4b7c3aab8c75525e92678123f84ca88b1
Add basic edit ldap auth test & actually fix #16252 (#16465) (#16494)

Backport #16465

One of the reasons why #16447 was needed and why #16268 was needed in
the first place was because it appears that editing ldap configuration
doesn't get tested.

This PR therefore adds a basic test that will run the edit pipeline.

In doing so it's now clear that #16447 and #16268 aren't actually
solving #16252. It turns out that what actually happens is that is that
the bytes are actually double encoded.

This PR now changes the json unmarshal wrapper to handle this double
encode.

Fix #16252

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
integrations/auth_ldap_test.go
models/login_source.go
models/repo_unit.go