]> source.dussan.org Git - vaadin-framework.git/commit
Check actual Grid selection instead of relying on allSelected flag. (#11787)
authorAnna Koskinen <Ansku@users.noreply.github.com>
Mon, 4 Nov 2019 11:26:32 +0000 (13:26 +0200)
committerGitHub <noreply@github.com>
Mon, 4 Nov 2019 11:26:32 +0000 (13:26 +0200)
commit0b627f975ddae79d4d9d1cf4b12e6c31eb31eb7a
tree32abf08c369e475e50b6a19322036bce2a435835
parentf5984b1cb69e32ea138c72dc2f2b47809cda74f8
Check actual Grid selection instead of relying on allSelected flag. (#11787)

The checkbox for selecting all rows only selects all the rows that have
not been filtered out. Changing the filtering does not change the
selection or the checkbox state so assuming that all rows are selected
simply because the checkbox has been checked cannot work.

Fixes #11479
client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java
server/src/main/java/com/vaadin/ui/components/grid/MultiSelectionModelImpl.java
uitest/src/main/java/com/vaadin/tests/components/grid/GridSelectAllFiltering.java [new file with mode: 0644]
uitest/src/test/java/com/vaadin/tests/components/grid/GridSelectAllFilteringTest.java [new file with mode: 0644]