]> source.dussan.org Git - gitea.git/commit
Clipboard copy enhancements (#27669)
authorsilverwind <me@silverwind.io>
Wed, 18 Oct 2023 15:16:06 +0000 (17:16 +0200)
committerGitHub <noreply@github.com>
Wed, 18 Oct 2023 15:16:06 +0000 (15:16 +0000)
commit0b654fa8dc132cce191f43fb9bdf4d5864e11b7c
tree2550ccfec53c0da4395dfd7ef704e6bd8b2ffff7
parent9852c92e9a633fdd318fde5014a12ef299b990ef
Clipboard copy enhancements (#27669)

1. Do not show temporary tooltips that are triggered from within
dropdowns. Previously this resulted in the tooltip being stuck to
top-left of the page like seen on issue comment URL copy. I could not
figure out any tippy options that prevent this, so I think it's better
to just not show it.
1. Refactor `initGlobalCopyToClipboardListener` so that it does not run
a often useless `document.querySelector` on every click, make
`data-clipboard-text-type` work with `data-clipboard-target`. No use in
current code base but still good to have. Finally some minor code
cleanup in the function.

Point 1 is for this copy button:

<img width="229" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/81f34746-8ea5-43d9-8c6f-f6f417a9e4ad">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
web_src/js/features/clipboard.js
web_src/js/modules/tippy.js