]> source.dussan.org Git - vaadin-framework.git/commit
Do not wait for icons to load before interacting with a combo box (#9717)
authorArtur <artur@vaadin.com>
Fri, 11 Aug 2017 13:07:51 +0000 (16:07 +0300)
committerHenri Sara <henri.sara@gmail.com>
Fri, 11 Aug 2017 13:07:51 +0000 (16:07 +0300)
commit0f64ae445bae3c6e7a0d7fee1b6db9717e3da59a
tree8dcc6f1fdbb0fccdba652fe017beb04650b11681
parent1f878089dec6c03090efbcc79b08edbfbffb7620
Do not wait for icons to load before interacting with a combo box (#9717)

Icon load detection code does not handle error events so broken images
will cause tests to fail forever. In other cases also, it seems very
rare to need icons to be loaded before interacting with a combo box. If
there really are use cases for this, it would be better to have a method
to query if all icons are loaded so that special tests can use this method.

Fixes https://github.com/vaadin/testbench/issues/916
client/src/main/java/com/vaadin/client/ui/VComboBox.java
uitest/src/main/java/com/vaadin/tests/elements/combobox/ComboBoxUI.java
uitest/src/test/java/com/vaadin/tests/elements/combobox/ComboBoxUITest.java