]> source.dussan.org Git - jgit.git/commit
projects / jgit.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2eeabde) | patch
ObjectWalk: Prefer boolean operators over logical operators in comparisons 90/143790/3
authorDavid Pursehouse <david.pursehouse@gmail.com>
Wed, 12 Jun 2019 05:21:39 +0000 (14:21 +0900)
committerMatthias Sohn <matthias.sohn@sap.com>
Sat, 15 Jun 2019 19:55:39 +0000 (21:55 +0200)
commit0f9063941cb5addf2edcb174750c07704fe5690a
treee3c61f008d450ef8a3f1018a61755cff17f62d65tree | snapshot
parent2eeabde94a4a39dd827d4ecc8110a6137d401cbacommit | diff
ObjectWalk: Prefer boolean operators over logical operators in comparisons

Using the | and & operators in boolean conditions results in a warning
from Error Prone:

  [ShortCircuitBoolean]
  Prefer the short-circuiting boolean operators && and || to & and |.
  see https://errorprone.info/bugpattern/ShortCircuitBoolean

Change-Id: I182f986263b8b9ac189907f4bd1662b4092a52d8
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/ObjectWalk.java diff | blob | history
JGit, the Java implementation of git: https://github.com/eclipse-jgit/jgit