]> source.dussan.org Git - gitea.git/commit
Fix `Permission` in API returned repository struct (#25388)
authorJason Song <i@wolfogre.com>
Thu, 22 Jun 2023 13:08:08 +0000 (21:08 +0800)
committerGitHub <noreply@github.com>
Thu, 22 Jun 2023 13:08:08 +0000 (13:08 +0000)
commit174213530dc538c124cddc5cc43d9a514c6695b9
tree061bdae4a57ed1ca17d1b85bb4c7ab69fe673d71
parent7fb539677b448a9cc554e71afb98da558f3e0631
Fix `Permission` in API returned repository struct (#25388)

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
22 files changed:
modules/structs/repo.go
routers/api/v1/org/team.go
routers/api/v1/repo/fork.go
routers/api/v1/repo/hook.go
routers/api/v1/repo/key.go
routers/api/v1/repo/migrate.go
routers/api/v1/repo/repo.go
routers/api/v1/repo/status.go
routers/api/v1/repo/transfer.go
routers/api/v1/user/repo.go
routers/api/v1/user/star.go
routers/api/v1/user/watch.go
routers/web/repo/webhook.go
services/actions/notifier.go
services/actions/notifier_helper.go
services/convert/activity.go
services/convert/notification.go
services/convert/package.go
services/convert/pull.go
services/convert/pull_test.go
services/convert/repository.go
services/webhook/notifier.go