]> source.dussan.org Git - vaadin-framework.git/commit
Enhanced tests and fix for #7668 - re-adding a component at an index before its curre...
authorJohannes Dahlström <johannes.dahlstrom@vaadin.com>
Thu, 24 Nov 2011 10:44:54 +0000 (10:44 +0000)
committerJohannes Dahlström <johannes.dahlstrom@vaadin.com>
Thu, 24 Nov 2011 10:44:54 +0000 (10:44 +0000)
commit1c6a751a5a1315b74b3e5adac337058e803e9d1f
treef397da1e7e075e5dfea40c8a126c0362f9caba2b
parent9d6099ffc787dbc2e95b74d0ad5741b231246c74
Enhanced tests and fix for #7668 - re-adding a component at an index before its current one does nothing

Simplified the logic in AbstractOrderedLayout/CssLayout#addComponent*() - super.addComponent() is now called first so that the invariant that there's never duplicate elements in the component list always holds, this fixes #7668. addComponent(c, index) now has a piece of additional logic handling the case when a component is moved to an index *after* its current one.

svn changeset:22117/svn branch:6.7
src/com/vaadin/ui/AbstractOrderedLayout.java
src/com/vaadin/ui/CssLayout.java
tests/server-side/com/vaadin/tests/server/component/abstractorderedlayout/AddComponentsTest.java
tests/server-side/com/vaadin/tests/server/component/csslayout/AddComponentsTest.java