]> source.dussan.org Git - vaadin-framework.git/commit
Use generated id of the menu item to help testing of the menubar (#12124) (#12156)
authorAnna Koskinen <Ansku@users.noreply.github.com>
Tue, 1 Dec 2020 12:35:24 +0000 (14:35 +0200)
committerGitHub <noreply@github.com>
Tue, 1 Dec 2020 12:35:24 +0000 (14:35 +0200)
commit24c52166dd41411c21350aabb8ef7490c83c0697
treef3da455abb36a03309859ad271e8b61df4d115bf
parent2c74ca8d63e987b4d2f5c2c90dbbc738f51efd0d
Use generated id of the menu item to help testing of the menubar (#12124) (#12156)

Use generated IDs for MenuItems when an ID is set for MenuBar. Tying the ID to MenuBar's ID helps with the possible case of having multiple MenuBars on the same view and avoids to have excess id's when not needed.

Fixes: https://github.com/vaadin/framework/issues/8186
Authored-by: Tatu Lund <tatu@vaadin.com>
client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java
uitest/src/test/java/com/vaadin/tests/components/menubar/MenuBarIconsTest.java