]> source.dussan.org Git - gitea.git/commit
Fix htmx rendering the login page in frame on session logout (#29405)
authorYarden Shoham <git@yardenshoham.com>
Mon, 26 Feb 2024 12:40:41 +0000 (14:40 +0200)
committerGitHub <noreply@github.com>
Mon, 26 Feb 2024 12:40:41 +0000 (20:40 +0800)
commit324626a11c041208b003ee64e33000b223994662
tree658e94d1a64d3010b8091ab2b5e7db02c47cc5d0
parent403766cd81697288804fd218d68c458c6aa5b73d
Fix htmx rendering the login page in frame on session logout (#29405)

- Fix #29391

With this change, htmx will not follow the redirect in the AJAX request
but instead redirect the whole browser.

To reproduce the bug fixed by this change without waiting a long time
for the token to expire, you can logout in another tab then look in the
original tab. Just make sure to comment out both instances of
`window.location.href = appSubUrl` in the codebase so you won't be
redirected immediately on logout. This is what I did in the following
gifs.

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
modules/context/base.go