]> source.dussan.org Git - gitea.git/commit
Fix restore repo bug, clarify the problem of ForeignIndex (#22776) (#22794)
authorYarden Shoham <hrsi88@gmail.com>
Wed, 8 Feb 2023 08:39:42 +0000 (10:39 +0200)
committerGitHub <noreply@github.com>
Wed, 8 Feb 2023 08:39:42 +0000 (08:39 +0000)
commit37bbf2c902736d22d7e4a1ce262945ae004c88c1
treec88243bfb7dcd03c501bc564f146b6439e2dcb15
parenta239d6c4a904c822f1af32545acb09ded8017d13
Fix restore repo bug, clarify the problem of ForeignIndex (#22776) (#22794)

Backport #22776

Fix #22581

TLDR: #18446 made a mess with ForeignIndex and triggered a design
flaw/bug of #16356, then a quick patch #21271 helped #18446, then the
the bug was re-triggered by #21721 .

Related:
* #16356
* BasicIssueContext
https://github.com/go-gitea/gitea/pull/16356/files#diff-7938eb670d42a5ead6b08121e16aa4537a4d716c1cf37923c70470020fb9d036R16-R27
* #18446
* If some issues were dumped without ForeignIndex, then they would be
imported as ForeignIndex=0
https://github.com/go-gitea/gitea/pull/18446/files#diff-1624a3e715d8fc70edf2db1630642b7d6517f8c359cc69d58c3958b34ba4ce5eR38-R39
* #21271
* It patched the above bug (somewhat), made the issues without
ForeignIndex could have the same value as LocalIndex
* #21721
    * It re-triggered the zero-ForeignIndex bug.

ps: I am not sure whether the changes in `GetForeignIndex` are ideal (at
least, now it has almost the same behavior as BasicIssueContext in
#16356), it's just a quick fix. Feel free to edit on this PR directly or
replace it.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
modules/migration/comment.go
modules/migration/issue.go
modules/migration/review.go