]> source.dussan.org Git - nextcloud-server.git/commit
Remove deprecated test of internal attributes via assertAttributeEquals in constructo... 22058/head
authorMorris Jobke <hey@morrisjobke.de>
Thu, 23 Jul 2020 11:44:18 +0000 (13:44 +0200)
committerMorris Jobke <hey@morrisjobke.de>
Thu, 30 Jul 2020 11:19:16 +0000 (13:19 +0200)
commit3ab2e4d41c15252f824f989a8e23f6bb8957dfb9
tree494dec59f11cdb6fba8747c49d624be78f01e8d1
parent67f22e28da1fe4e6c409991a4ac7e7c0cb6747c9
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests

I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
tests/lib/Template/CSSResourceLocatorTest.php
tests/lib/Template/JSResourceLocatorTest.php
tests/lib/Template/ResourceLocatorTest.php