]> source.dussan.org Git - gitea.git/commit
Fix incorrect diff expander for deletion of last lines in a file (#29501)
authorsilverwind <me@silverwind.io>
Fri, 1 Mar 2024 16:12:21 +0000 (17:12 +0100)
committerGitHub <noreply@github.com>
Fri, 1 Mar 2024 16:12:21 +0000 (16:12 +0000)
commit3b99066aa866e51e6a610716eaddfd1ea3645a67
tree7441a989c40f67aab6823b5b51e21459f502a546
parent6841e58d1fae33311fa0239823def9dd8fba4c1f
Fix incorrect diff expander for deletion of last lines in a file (#29501)

Fixes: https://github.com/go-gitea/gitea/issues/29498
I don't quite understand this code, but this change does seem to fix the
issue and I tested a number of diffs with it and saw no issue. The
function gets such value if last line is an addition:

```
  LastLeftIdx: (int) 0,
  LastRightIdx: (int) 47,
  LeftIdx: (int) 47,
  RightIdx: (int) 48,
```

If it's a deletion, it gets:

```
  LastLeftIdx: (int) 47,
  LastRightIdx: (int) 0,
  LeftIdx: (int) 48,
  RightIdx: (int) 47,
```

So I think it's correct to make this check respect both left and right
side.
services/gitdiff/gitdiff.go