]> source.dussan.org Git - gitea.git/commit
Include OriginalAuthor in Reaction constraint (#13505)
authorzeripath <art27@cantab.net>
Tue, 10 Nov 2020 22:37:11 +0000 (22:37 +0000)
committerGitHub <noreply@github.com>
Tue, 10 Nov 2020 22:37:11 +0000 (22:37 +0000)
commit3fd060eb37085df9b075baf23f3c315b92c1073e
tree58659f779495b8cbfa2cf576d654dbd490fe09c5
parent3400928f7ac1fe8326a69a049a5c0b2dc3a3675d
Include OriginalAuthor in Reaction constraint (#13505)

When migrating repositories with reactions with deleted users, the original
author id may be -1. This means that it is possible to end up attempting
to create multiple reactions with the same [ Type, IssueID, CommentID, UserID,
OriginalAuthorID ] thus breaking the constraints.

On SQLite this appears to cause a deadlock but on other dbs this will
cause the migration to fail.

This PR extends the constraint to include the original author username
in the constraint.

Fix #13271

Signed-off-by: Andrew Thornton <art27@cantab.net>
models/issue_reaction.go
models/migrations/migrations.go
models/migrations/v159.go [new file with mode: 0644]