]> source.dussan.org Git - gitea.git/commit
Fix `aria.js` bugs: incorrect role element problem, mobile focus problem, tippy...
authorwxiaoguang <wxiaoguang@gmail.com>
Sat, 18 Mar 2023 16:14:19 +0000 (00:14 +0800)
committerGitHub <noreply@github.com>
Sat, 18 Mar 2023 16:14:19 +0000 (17:14 +0100)
commit420d015b76a49e1018c3f1b73ce3b9f72d86f78c
tree23cc9de581cf8f567ee0acfe55bf263d0a27ca1c
parent22911a1ece5bd08648e10b7ffcb3308d204180ee
 Fix `aria.js` bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) (#23486)

Before: the `aria.js` is still buggy in some cases.

After: tested with AppleVoice, Android TalkBack (I tested it with 1.19
again)

* Fix incorrect dropdown init code
* Fix incorrect role element (the menu role should be on the `$menu`
element, but not on the `$focusable`)
* Fix the focus-show-click-hide problem on mobile. Now the language menu
works as expected
* Fix incorrect dropdown template function setting
* Clarify the logic in aria.js
* Fix incorrect tippy `setProps` after `destroy`
* Improve comments
* Implement the layout proposed by #19861
templates/base/footer_content.tmpl
templates/repo/issue/view_content/add_reaction.tmpl
templates/repo/issue/view_content/context_menu.tmpl
web_src/js/features/aria.js
web_src/js/features/aria.md
web_src/js/features/common-global.js
web_src/js/features/repo-legacy.js
web_src/js/modules/tippy.js