]> source.dussan.org Git - gitea.git/commit
Reduce memory usage for chunked artifact uploads to MinIO (#31325)
authorRowan Bohde <rowan.bohde@gmail.com>
Wed, 12 Jun 2024 11:34:35 +0000 (06:34 -0500)
committerGitHub <noreply@github.com>
Wed, 12 Jun 2024 11:34:35 +0000 (11:34 +0000)
commit45dbeb5600d1f552c0134721fe49e8fd1099b5a4
treec50d4012699c47e03ad0c596c4e635476719d6ca
parent130ea31d6d4105d466185759186c5ece5148731f
Reduce memory usage for chunked artifact uploads to MinIO (#31325)

When using the MinIO storage driver for Actions Artifacts, we found that
the chunked artifact required significantly more memory usage to both
upload and merge than the local storage driver. This seems to be related
to hardcoding a value of `-1` for the size to the MinIO client [which
has a warning about memory usage in the respective
docs](https://pkg.go.dev/github.com/minio/minio-go/v7#Client.PutObject).
Specifying the size in both the upload and merge case reduces memory
usage of the MinIO client.

Co-authored-by: Kyle D <kdumontnu@gmail.com>
routers/api/actions/artifacts_chunks.go