]> source.dussan.org Git - jgit.git/commit
BaseReceivePack: Treat all LFs as optional 36/51436/3
authorDave Borowitz <dborowitz@google.com>
Mon, 6 Jul 2015 19:19:42 +0000 (15:19 -0400)
committerDave Borowitz <dborowitz@google.com>
Tue, 7 Jul 2015 19:44:17 +0000 (15:44 -0400)
commit469734bf871b8307b2c83817c63b312a9e7d366d
treefa0eea2bba5894ebbded84af1370d08447286322
parent59b000a6720c780b1620b7149ce14c9f81d796de
BaseReceivePack: Treat all LFs as optional

Discussion on the git mailing list has concluded[1] that the intended
behavior for all (non-sideband) portions of the receive-pack protocol
is for trailing LFs in pkt-lines to be optional. Go back to using
PacketLineIn#readString() everywhere.

For push certificates specifically, we agreed that the payload signed
by the client is always concatenated with LFs even though the client
MAY omit LFs when framing the certificate for the wire. This is still
reflected in the implementation of PushCertificate#toText().

[1] http://thread.gmane.org/gmane.comp.version-control.git/273175/focus=273412

Change-Id: I817231c4d4defececb8722142fea18ff42e06e44
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/BaseReceivePackTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/PushCertificateParserTest.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/BaseReceivePack.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificate.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java