]> source.dussan.org Git - vaadin-framework.git/commit
Simplify Grid scroll handling. (#11835)
authorAnna Koskinen <Ansku@users.noreply.github.com>
Tue, 3 Dec 2019 11:13:49 +0000 (13:13 +0200)
committerTatu Lund <tatu@vaadin.com>
Tue, 3 Dec 2019 11:13:49 +0000 (13:13 +0200)
commit4dc4f83865d72fc3d56a96a4a01db1a36e959908
treeb76a96017a6af9a53560fd5306b893b51b8e7e9e
parent252ef116342a6b0363b48d157de33a932d44752f
Simplify Grid scroll handling. (#11835)

If first attempt at scrolling doesn't succeed it's unlikely that
continuing to wait is going to make any difference. Cache should be
populated before triggering any actions that depend on the row being
visible, otherwise it should be enough to trust that scrollToRow
actually scrolls to row and once scrolling is done the row is as much in
view as it's going to get. This way we don't get into a situation where
Editor never opens because it's still waiting for that one last pixel
that can't be achieved thanks to browser zoom causing rounding errors.

Continues on #11672
client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
client/src/main/java/com/vaadin/client/widgets/Escalator.java
client/src/main/java/com/vaadin/client/widgets/Grid.java