]> source.dussan.org Git - gitea.git/commit
Convert issue list checkboxes to native (#23596)
authorsilverwind <me@silverwind.io>
Thu, 30 Mar 2023 15:02:47 +0000 (17:02 +0200)
committerGitHub <noreply@github.com>
Thu, 30 Mar 2023 15:02:47 +0000 (11:02 -0400)
commit525b7382d31079333dbffba625af1c0e177546db
tree1958a54d500b9e0a997f7d10d518568c0e3da036
parent964a057a76793c32c81394505e2f480a4bf40d0d
Convert issue list checkboxes to native (#23596)

Use native instead of fomantic checkboxes in issue list. Benefits
include no more JS pop-in on load and perfect a11y.

Before, with JS pop-in:

<img width="92" alt="Screenshot 2023-03-20 at 17 02 02"
src="https://user-images.githubusercontent.com/115237/226398955-99029a1c-1150-449c-821b-e4165e7446a8.png">

After, Firefox on macOS:

<img width="126" alt="Screenshot 2023-03-20 at 17 01 26"
src="https://user-images.githubusercontent.com/115237/226399018-58df2c32-c2b2-4c78-b7df-7b76523abe21.png">

After, Chrome on macOS:

<img width="79" alt="Screenshot 2023-03-20 at 17 01 42"
src="https://user-images.githubusercontent.com/115237/226399074-947e6279-8dc3-42c2-90b5-b106c471b23d.png">

I opted to not do styling yet but I see that the inconsistency between
browsers may already be reason enough on doing it. I think if we style
them, there should be one global style, including markdown ones which
currently have custom styling.
templates/repo/issue/list.tmpl
templates/shared/issuelist.tmpl
web_src/css/helpers.css
web_src/css/shared/issuelist.css
web_src/js/features/common-issue.js