]> source.dussan.org Git - jgit.git/commit
AdvertisedRequestValidator: fix WantNotValidException caused by race 80/1201680/3 stable-6.6
authorMatthias Sohn <matthias.sohn@sap.com>
Tue, 24 Sep 2024 08:51:22 +0000 (10:51 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Wed, 25 Sep 2024 14:43:52 +0000 (16:43 +0200)
commit56a5db65b3e6c0c838b29071323332439dbbc08f
tree9483725034365153165e8b97e16110c91e49f286
parentf9cc863220814d70440766c3ac80c61bc69cae4f
AdvertisedRequestValidator: fix WantNotValidException caused by race

Fetch with protocol V2 failed under the following conditions
- fetch uses bidirectional protocol (git, ssh) which uses a shortcut
  to determine invalid wants
- not all wants are advertised
- race condition: wanted ref is updated during fetch by another thread
  after the thread serving upload-pack determined wants and before it
  checks not advertised wants

Fix this by calling
`new ReachableCommitRequestValidator().checkWants(up, wants)`
instead of throwing WantNotValidException in [1]
if this race happened in the same way like it's done for unidirectional
protocols (http) [2].

[1] https://github.com/eclipse-jgit/jgit/blob/stable-6.10/org.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java#L2002
[2] https://github.com/eclipse-jgit/jgit/blob/stable-6.10/org.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java#L2000

Bug: jgit-48
Change-Id: I32f28502923815dc49781aab5d810c9afbe7e7e6
org.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java