]> source.dussan.org Git - gitea.git/commit
Fix PATCH /repos/{owner}/{repo} panic (#14637)
authorAnton Khimich <anton.khimich@gmail.com>
Thu, 11 Feb 2021 19:53:41 +0000 (14:53 -0500)
committerGitHub <noreply@github.com>
Thu, 11 Feb 2021 19:53:41 +0000 (20:53 +0100)
commit5a18712dd7dcffecf88d3071381a836a543d8f2a
tree56772aae2f83be47ccd416b506f522a5f6845d78
parent441f3f0f205234e8cb8d7bac90ed115ebd2e9d43
Fix PATCH /repos/{owner}/{repo} panic (#14637)

* Fix a runtime error when modifying a repository through API call

Using the `PATCH /repos/{owner}/{repo}` endpoint and attempting to
modify `default_branch` on an empty repository will cause a
panic. This commit adds a check for a nil pointer before attempting
to dereference it.

* Apply suggestions from code review

* Apply suggestions from code review

* Ensure that the git repository is loaded

If you change the default branch for a repository you must change it in
git too. Therefore you must open the repository before changing the
default branch.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Allow empty repos to have their default branches changed

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Anton Khimich <anton.khimicha@mail.utoronto.ca>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Andrew Thornton <art27@cantab.net>
routers/api/v1/repo/repo.go