]> source.dussan.org Git - jgit.git/commit
Format @Nullable on return value as method annotation 15/130715/1
authorJonathan Nieder <jrn@google.com>
Tue, 9 Oct 2018 22:48:16 +0000 (15:48 -0700)
committerJonathan Nieder <jrn@google.com>
Tue, 9 Oct 2018 22:52:54 +0000 (15:52 -0700)
commit608b6b03b1182329ae6f76a4c3938874dcc9c210
tree389e36d9e1e4cba97da419a68d474ab043cbd5d8
parentc58362c1748abceacf35fc6b3d0d53125f7cdf71
Format @Nullable on return value as method annotation

For example, instead of using

public @Nullable String getMyFavoriteString() { ... }

use

@Nullable
public String getMyFavoriteString() { ... }

This makes the style more consistent (the existing JGit code base
tends to lean toward the second style) and makes the source code
better reflect how the annotation is parsed, as a METHOD annotation.

Longer term, we should switch to a TYPE_USE annotation and switch to
the first style.

Noticed using a style checker that follows
https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations

Change-Id: I07f4e67cc149fb8007f696a4663e10d4bfc57e3a
Reported-by: Ivan Frade <ifrade@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsRepository.java
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/BuiltinLFS.java
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/AtomicObjectOutputStream.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/TransferConfig.java
org.eclipse.jgit/src/org/eclipse/jgit/util/LfsFactory.java
org.eclipse.jgit/src/org/eclipse/jgit/util/RawParseUtils.java