]> source.dussan.org Git - vaadin-framework.git/commit
Fix occasional empty rows in Table and TreeTable (#9551)
authormlindfors <majuli@vaadin.com>
Wed, 9 Aug 2017 11:14:10 +0000 (14:14 +0300)
committerHenri Sara <henri.sara@gmail.com>
Wed, 9 Aug 2017 11:14:10 +0000 (14:14 +0300)
commit62d50a66e0216eb5210e93ef39cce8dbdde0ca9f
tree94295175307b74cf2f38c1273cdd6656bb3dc414
parente981dfbe1f782ae93844886270cac9651be5fb8d
Fix occasional empty rows in Table and TreeTable (#9551)

There's an intermittently happening issue with both Table and TreeTable, which results in row data disappearing.
This change removes a method which is probably a vestigial one from over five years ago and other changes are handling the things the method used to perform. Currently the method removes rows deemed unnecessary from the row buffer. The problem is, those rows are visible to the user and removing causes row contents to be lost.
Also included are manually runnable test cases which demonstrate that this removal actually prevents the issue from happening.

Fixes #7964
Fixes #5030
server/src/main/java/com/vaadin/ui/Table.java
uitest/src/main/java/com/vaadin/tests/components/table/ComponentsDisappearWhenScrolling.java [new file with mode: 0644]
uitest/src/main/java/com/vaadin/tests/components/treetable/TreeTableComponentsDisappearWhenScrolling.java [new file with mode: 0644]