]> source.dussan.org Git - jquery.git/commit
Selector: Stop relying on CSS.supports( "selector(...)" )
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Tue, 14 Feb 2023 10:42:29 +0000 (11:42 +0100)
committerGitHub <noreply@github.com>
Tue, 14 Feb 2023 10:42:29 +0000 (11:42 +0100)
commit63c3af481c7010920bca68518c434cd27ab22cb2
treebc90f102ca1c39ca5a522fa41b18af27e092ee2f
parentac1c59a354c1e333cbe3c40f3b3dc7f644d81f6b
Selector: Stop relying on CSS.supports( "selector(...)" )

`CSS.supports( "selector(...)" )` has different semantics than selectors passed
to `querySelectorAll`. Apart from the fact that the former returns `false` for
unrecognized selectors and the latter throws, `qSA` is more forgiving and
accepts some invalid selectors, auto-correcting them where needed - for
example, mismatched brackers are auto-closed. This behavior difference is
breaking for many users.

To add to that, a recent CSSWG resolution made `:is()` & `:where()` the only
pseudos with forgiving parsing; browsers are in the process of making `:has()`
parsing unforgiving.

Taking all that into account, we go back to our previous try-catch approach
without relying on `CSS.supports( "selector(...)" )`. The only difference
is we detect forgiving parsing in `:has()` and mark the selector as buggy.

The PR also updates `playwright-webkit` so that we test against a version
of WebKit that already has non-forgiving `:has()`.

Fixes gh-5194
Closes gh-5207
Ref gh-5206
Ref gh-5098
Ref gh-5107
Ref w3c/csswg-drafts#7676
package.json
src/selector.js
test/unit/support.js