]> source.dussan.org Git - gitea.git/commit
projects / gitea.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7e294ad) | patch
Fix profile page email display, respect settings (#23747)
authorwxiaoguang <wxiaoguang@gmail.com>
Mon, 27 Mar 2023 21:27:32 +0000 (05:27 +0800)
committerGitHub <noreply@github.com>
Mon, 27 Mar 2023 21:27:32 +0000 (17:27 -0400)
commit6706ac2a0f5f2fe4f8e2555be7e2a8b4d5946398
tree2098ea5d2e81839f7d30840c460586da22c91572tree | snapshot
parent7e294ad9514198e47b2b32c608c162cee0e9192acommit | diff
Fix profile page email display, respect settings (#23747)

Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate`
setting.

* It doesn't make sense to show user's own E-mail to themself.
* Always hide the E-mail if KeepEmailPrivate=true, then the user could
know how their profile page looks like for others.
* Revert the `setting.UI.ShowUserEmail` change from #4981 . This setting
is used to control the E-mail display, not only for the user list page.

ps: the incorrect `<div .../>` tag on the profile page has been fixed by
#23748 together, so this PR becomes simpler.
routers/web/user/profile.go diff | blob | history
tests/integration/setting_test.go diff | blob | history
Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD: https://github.com/go-gitea/gitea