]> source.dussan.org Git - gitea.git/commit
Ignore error when retrieving changed PR review files (#21487) (#21524)
authordelvh <leon@kske.dev>
Thu, 20 Oct 2022 15:25:54 +0000 (17:25 +0200)
committerGitHub <noreply@github.com>
Thu, 20 Oct 2022 15:25:54 +0000 (23:25 +0800)
commit675c14aba660fcda7912519035a785e10ea61431
tree63dbbfb6f7fbe116e596b774f097f964a13ccdf0
parent4b4adb1cc924ba086a89b309869690903b776d6c
Ignore error when retrieving changed PR review files (#21487) (#21524)

When a PR reviewer reviewed a file on a commit that was later gc'ed,
they would always get a `500` response from then on when loading the PR.
This PR simply ignores that error and instead marks all files as
unchanged.
This approach was chosen as the only feasible option without diving into
**a lot** of error handling.

Fixes #21392
Backport of #21487

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
services/gitdiff/gitdiff.go