]> source.dussan.org Git - gitea.git/commit
Improve AJAX link and modal confirm dialog (#25210)
authorwxiaoguang <wxiaoguang@gmail.com>
Tue, 13 Jun 2023 12:10:10 +0000 (20:10 +0800)
committerGitHub <noreply@github.com>
Tue, 13 Jun 2023 12:10:10 +0000 (12:10 +0000)
commit6bbccdd177bcbac600e3019062c96339a121851a
tree92d53bbdd976b6b8657b10ccda910a08d094dc81
parenta51b115b0ad755562c71f6a382326c59868dfb96
Improve AJAX link and modal confirm dialog (#25210)

Clarify the "link-action" behavior:

>  // A "link-action" can post AJAX request to its "data-url"
> // Then the browser is redirect to: the "redirect" in response, or
"data-redirect" attribute, or current URL by reloading.

And enhance the "link-action" to support showing a modal dialog for
confirm. A similar general approach could also help PRs like
https://github.com/go-gitea/gitea/pull/22344#discussion_r1062883436

> // If the "link-action" has "data-modal-confirm(-html)" attribute, a
confirm modal dialog will be shown before taking action.

And a lot of duplicate code can be removed now. A good framework design
can help to avoid code copying&pasting.

---------

Co-authored-by: silverwind <me@silverwind.io>
templates/admin/user/edit.tmpl
templates/base/head_script.tmpl
templates/org/settings/options.tmpl
templates/org/team/members.tmpl
templates/org/team/repositories.tmpl
templates/repo/branch/list.tmpl
templates/repo/settings/options.tmpl
templates/user/settings/profile.tmpl
tests/integration/branches_test.go
web_src/css/org.css
web_src/js/features/common-global.js