]> source.dussan.org Git - aspectj.git/commit
JoinPointImpl: Remove thread-locals after usage, where possible
authorKimmingLau <294001791@qq.com>
Wed, 3 Apr 2024 20:20:18 +0000 (04:20 +0800)
committerAlexander Kriegisch <Alexander@Kriegisch.name>
Wed, 10 Apr 2024 09:23:00 +0000 (11:23 +0200)
commit70a454761097fc22918861c53db1f09445b685bb
tree300c5f5d2c7825d7d51f25096b60e335e44dbc10
parent856db5d97f329041751418b2cc43d7574e26144d
JoinPointImpl: Remove thread-locals after usage, where possible

Avoid potential ThreadLocalMap.Entry accumulation. Entry is a
WeakReference. When JoinPointImpl objects are collected by GC, Entry
instances are still be referenced by ThreadLocalMap, which leads to
memory pressure and potentially more full GCs. So, we proactively remove
ThreadLocal<Integer> arcIndex instances when arcIndex has been
decremented back to -1 per thread. This is not perfect, because not each
thread can be expected to proceed, but it should ameliorate the
situation to some degree.

Fixes #302.

Co-authored-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Signed-off-by: KimmingLau <294001791@qq.com>
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
runtime/src/main/java/org/aspectj/runtime/reflect/JoinPointImpl.java