]> source.dussan.org Git - vaadin-framework.git/commit
Fixed DragAndDropWrapper using wrong drop target in IE8 #12406
authorJohn Ahlroos <john@vaadin.com>
Tue, 20 Aug 2013 10:30:47 +0000 (13:30 +0300)
committerVaadin Code Review <review@vaadin.com>
Tue, 20 Aug 2013 12:47:50 +0000 (12:47 +0000)
commit7220ca8758e44ae84ae5c9ef0623dc9585f6d171
tree0e7fca68a7ac22012c29a8662af9a0ad984fb065
parentb5a212a8c87a7370c385aeec22ea98a58fc7b051
Fixed DragAndDropWrapper using wrong drop target in IE8 #12406

VDragAndDropManager was assuming that the target element will always be
inside the cloned "drag image" element while dragging. This assumption
is false since the "drag image" can be 0x0px or transparent effectivly
disabling dragging.

Since Testbench 2 is also very flaky in using the Vaadin locators with
the drag/drop commands I replaced the locators with shorter locators
using a debug id to make the test more readable and stable.

Change-Id: I2cc9683d11e982521e74418c74dd3e81ee617ac5
client/src/com/vaadin/client/ui/dd/VDragAndDropManager.java
uitest/src/com/vaadin/tests/components/draganddropwrapper/DragAndDropDisable.html
uitest/src/com/vaadin/tests/components/draganddropwrapper/DragAndDropDisable.java