]> source.dussan.org Git - nextcloud-server.git/commit
projects / nextcloud-server.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3904acf) | patch
Remove deprecated test of internal attributes via assertAttributeEquals
authorMorris Jobke <hey@morrisjobke.de>
Thu, 23 Jul 2020 11:36:49 +0000 (13:36 +0200)
committerMorris Jobke <hey@morrisjobke.de>
Thu, 30 Jul 2020 11:18:14 +0000 (13:18 +0200)
commit7a49d0fbeadd6825cf45031e9bb9ab0e308039d5
tree6ae1c0beb073973e7ec9b3abfab58a8b57404218tree | snapshot
parent3904acfe932be26be71daf2ae047a144ac8b48c9commit | diff
Remove deprecated test of internal attributes via assertAttributeEquals

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
tests/lib/ConfigTest.php diff | blob | history
tests/lib/DB/DBSchemaTest.php diff | blob | history
Nextcloud server, a safe home for all your data: https://github.com/nextcloud/server