]> source.dussan.org Git - gitea.git/commit
Update milestone counters when issue is deleted (#21459)
authorAshley Nelson <fant@shley.email>
Sat, 22 Oct 2022 15:08:10 +0000 (10:08 -0500)
committerGitHub <noreply@github.com>
Sat, 22 Oct 2022 15:08:10 +0000 (23:08 +0800)
commit82ecd3b19eb1382521b7999bd0e2dd977c3b994d
treee6b937584fd67460fda54642b23c74736d0cccf2
parent154efa59a5a837d8375c09fb0b18a1b63bea6a3a
Update milestone counters when issue is deleted (#21459)

When actions besides "delete" are performed on issues, the milestone
counter is updated. However, since deleting issues goes through a
different code path, the associated milestone's count wasn't being
updated, resulting in inaccurate counts until another issue in the same
milestone had a non-delete action performed on it.

I verified this change fixes the inaccurate counts using a local docker
build.

Fixes #21254

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
models/migrations/fixtures/Test_updateOpenMilestoneCounts/expected_milestone.yml [new file with mode: 0644]
models/migrations/fixtures/Test_updateOpenMilestoneCounts/issue.yml [new file with mode: 0644]
models/migrations/fixtures/Test_updateOpenMilestoneCounts/milestone.yml [new file with mode: 0644]
models/migrations/migrations.go
models/migrations/v229.go [new file with mode: 0644]
models/migrations/v229_test.go [new file with mode: 0644]
services/issue/issue.go