]> source.dussan.org Git - vaadin-framework.git/commit
Do full connector tracker cleanup when the session lock is released (#9707)
authorArtur <artur@vaadin.com>
Mon, 24 Jul 2017 05:43:52 +0000 (08:43 +0300)
committerHenri Sara <henri.sara@gmail.com>
Mon, 24 Jul 2017 05:43:52 +0000 (08:43 +0300)
commit94f2e1f4227c59b21011747ab04ed553cfa235a8
tree52852074a507c5f9dafed71f978883385ba8ecd5
parent913e55ae4084c1f3e8c41b7620f3d7496710ba03
Do full connector tracker cleanup when the session lock is released (#9707)

As there is no "request end" call after invoking UI.access() from a background thread,
the connector map was not earlier properly cleaned afterwards. If you toggled visibility of a
component from the background thread, the tracker state became inconsistent.

If this becomes a performance problem, it could probably be optimized to that cleanup
is done in request end and only at the end of access if not inside a request.

Fixes #9654
server/src/main/java/com/vaadin/server/VaadinService.java
server/src/main/java/com/vaadin/server/VaadinSession.java
server/src/main/java/com/vaadin/ui/ConnectorTracker.java
uitest/src/main/java/com/vaadin/tests/application/MissingHierarchyDetection.java
uitest/src/main/java/com/vaadin/tests/push/PushToggleComponentVisibility.java [new file with mode: 0644]
uitest/src/test/java/com/vaadin/tests/push/PushToggleComponentVisibilityTest.java [new file with mode: 0644]