]> source.dussan.org Git - gitea.git/commit
Use correct response code in push mirror creation response in v1_json.tmpl (#25476)
authorGeorg Dangl <10274404+GeorgDangl@users.noreply.github.com>
Wed, 28 Jun 2023 22:00:19 +0000 (00:00 +0200)
committerGitHub <noreply@github.com>
Wed, 28 Jun 2023 22:00:19 +0000 (22:00 +0000)
commit953884236454e6e6a9e23dac21b8a4c124689723
tree6f09929e7d02e6efe76c012ae70bd026a1dbc81b
parentb4d0036fc3e0657806e550431bf1d5420349472a
Use correct response code in push mirror creation response in v1_json.tmpl (#25476)

In the process of doing a bit of automation via the API, we've
discovered a _small_ issue in the Swagger definition. We tried to create
a push mirror for a repository, but our generated client raised an
exception due to an unexpected status code.

When looking at this function:

https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L236-L240

We see it defines `201 - Created` as response:

https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L260-L262

But it actually returns `200 - OK`:

https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L373

So I've just updated the Swagger definitions to match the code😀

---------

Co-authored-by: Giteabot <teabot@gitea.io>
routers/api/v1/repo/mirror.go
templates/swagger/v1_json.tmpl