]> source.dussan.org Git - vaadin-framework.git/commit
Improvements to ScrollDestination sanity checks (#11772) (#11776) 8.9.2
authorAnna Koskinen <Ansku@users.noreply.github.com>
Mon, 28 Oct 2019 17:46:32 +0000 (19:46 +0200)
committerTatu Lund <tatu@vaadin.com>
Mon, 28 Oct 2019 17:46:32 +0000 (19:46 +0200)
commit95a01fe72ea115bd6816f45bcb97423544df4ea3
tree059188ef7a5088aa62f657df1d565db194b82bbb
parent55753a2e9d0385736cd3fd831573d2faddb801ef
Improvements to ScrollDestination sanity checks (#11772) (#11776)

- The new top row logical index should always be within the logical
range and high enough up to avoid leaving a gap if possible.
- Added regression testing for using the different scroll destination
types for scrolling to the top and to the bottom by index.

Fixes #11732
client/src/main/java/com/vaadin/client/widgets/Escalator.java
uitest/src/test/java/com/vaadin/tests/components/grid/GridScrollDestinationTest.java