]> source.dussan.org Git - vaadin-framework.git/commit
Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)
authorAnna Koskinen <Ansku@users.noreply.github.com>
Thu, 21 Nov 2019 05:43:14 +0000 (07:43 +0200)
committerTatu Lund <tatu@vaadin.com>
Thu, 21 Nov 2019 05:43:14 +0000 (07:43 +0200)
commit97d4222a28fecf03c636b392ec976113769b062f
treed38337294dc029ee996197aace386768342fd206
parentce497adfbdb6875e3cbe783cfc280999a9ae04d9
Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)

The attempt gets blocked later down the line in any case and never
reaches the server, but sending it messes up TreeGrid's internal state.
It gets stuck waiting for the resolution of the blocked call that can
then only be resolved by server-side sending its own expand/collapse
request programmatically. Until that happens no further expand/collapse
attempts will get sent to server even after the TreeGrid has been
enabled again.

Tree is also affected as it is built upon TreeGrid.

Fixes #11822
client/src/main/java/com/vaadin/client/ui/treegrid/TreeGridConnector.java
uitest/src/main/java/com/vaadin/tests/components/tree/TreeBasicFeatures.java
uitest/src/test/java/com/vaadin/tests/components/tree/TreeBasicFeaturesTest.java
uitest/src/test/java/com/vaadin/tests/components/treegrid/TreeGridBasicFeaturesTest.java