]> source.dussan.org Git - gitea.git/commit
projects / gitea.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e579ddc) | patch
Refactor DeleteInactiveUsers, fix bug and add tests (#30206) (#30222)
authorGiteabot <teabot@gitea.io>
Mon, 1 Apr 2024 04:58:46 +0000 (12:58 +0800)
committerGitHub <noreply@github.com>
Mon, 1 Apr 2024 04:58:46 +0000 (12:58 +0800)
commit98a81bef17b7aaa1f88db597f86d1f40cd926566
treed85aeec94a19e52a7104ca50484943a4196ca1ebtree | snapshot
parente579ddc31f6d6d0406f1c5330f2a31b9707fb3e2commit | diff
Refactor DeleteInactiveUsers, fix bug and add tests (#30206) (#30222)

Backport #30206 by wxiaoguang

1. check `IsActive` before calling `IsLastAdminUser`.
2. Fix some comments and error messages.
3. Don't `return err` if "removing file" fails in `DeleteUser`.
4. Remove incorrect `DeleteInactiveEmailAddresses`. Active users could
also have inactive emails, and inactive emails do not support
"olderThan"
5. Add tests

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
models/user/email_address.go diff | blob | history
services/user/user.go diff | blob | history
services/user/user_test.go diff | blob | history
Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD: https://github.com/go-gitea/gitea