]> source.dussan.org Git - gitea.git/commit
Replies to outdated code comments should also be outdated (#13217) (#13433)
author6543 <6543@obermui.de>
Thu, 5 Nov 2020 20:14:55 +0000 (21:14 +0100)
committerGitHub <noreply@github.com>
Thu, 5 Nov 2020 20:14:55 +0000 (15:14 -0500)
commit9aa580ce0e8791ddfcc1548c6a5ca516213bf785
treea74a9182201d35e9046670274386e3d2c92f1bec
parent3421e4b756f7491ab4490a76c4a8239896680eea
Replies to outdated code comments should also be outdated (#13217) (#13433)

* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
models/issue_comment.go
services/pull/review.go