]> source.dussan.org Git - vaadin-framework.git/commit
Bottom component click scroll up the parent panel in a window (#12943)
authorBogdan Udrescu <bogdan@vaadin.com>
Tue, 8 Jul 2014 06:58:45 +0000 (09:58 +0300)
committerBogdan Udrescu <bogdan@vaadin.com>
Tue, 29 Jul 2014 14:05:09 +0000 (17:05 +0300)
commit9cb08a806fe5745cf6b15e57374a60c9cddbaa25
tree2dd411e46ebf31a4267b5caa3d6926e3580905ee
parentf706f663c3e3b49cdb1ab5e4f260ce7c7a7e4836
Bottom component click scroll up the parent panel in a window (#12943)

Due to old fix for (#11994) the v-scrollable div of the window would
expand to 110% of its size then immediately back to the original size.
The first action, expanding the v-scrollable to 110% would decrease
the scrollTop value of our panel, while increasing its height. When
the revert back action would set the v-scrollable to its own size,
the panel's scrollTop would remain decreased, causing the scroll bar
to move up, hiding the ~10% at the bottom.

Fixed by calling Util.runWebkitOverflowAutoFix(); instead of changing
the height.

Change-Id: I79eafd1f9500c2e4c10dadbfc7100608c0732e04
WebContent/html-tests/BottomComponentScrollsUp.html [new file with mode: 0644]
client/src/com/vaadin/client/ApplicationConnection.java
client/src/com/vaadin/client/Util.java
client/src/com/vaadin/client/ui/VScrollTable.java
client/src/com/vaadin/client/ui/VWindow.java
client/src/com/vaadin/client/ui/table/TableConnector.java
uitest/src/com/vaadin/tests/components/window/BottomComponentScrollsUp.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/window/BottomComponentScrollsUpTest.java [new file with mode: 0644]