]> source.dussan.org Git - gitea.git/commit
Prevent NPE in CommentMustAsDiff if no hunk header (#15199)
authorzeripath <art27@cantab.net>
Thu, 1 Apr 2021 18:29:14 +0000 (19:29 +0100)
committerGitHub <noreply@github.com>
Thu, 1 Apr 2021 18:29:14 +0000 (14:29 -0400)
commita351b22dc0319a99ef68048529e533c7e91a9c8c
treecc0252f37489cf8c25ae4139cf0f38cf6c01dd2f
parentff460ca74d37b1eadac63b8858d0daa1690e0e2f
Prevent NPE in CommentMustAsDiff if no hunk header (#15199)

I do not understand how this can happen or why.

There is an apparent possibility for a comment.Patch to be missing a hunk header
- this should not happen and do not understand how. But it appears to happen on
1.13 at least in some case.

This PR will simply add a new section if the cursection is empty
thus preventing the NPE.

Fix #15198

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
services/gitdiff/gitdiff.go