]> source.dussan.org Git - jgit.git/commit
UnionInputStreamTest: Suppress ErrorProne warning about missing synchronized 26/130826/3
authorDavid Pursehouse <david.pursehouse@gmail.com>
Fri, 12 Oct 2018 02:07:48 +0000 (11:07 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Wed, 17 Oct 2018 01:29:33 +0000 (10:29 +0900)
commitabefc00ac58837e2f7933fbf450a74e8d673aa00
treee6c6125d292c29c4f7cfc19d214a7840a076a5c3
parent9bfd31fd44267b82d01c99fe9a6a3f9ea3ec6a68
UnionInputStreamTest: Suppress ErrorProne warning about missing synchronized

Error Prone reports that the unsynchronized method skip overrides the
synchronized method in ByteArrayInputStream [1].

This is a test class, so we can just suppress the warning as recommended
in [1].

Note that the suppression causes a warning in Eclipse, because it doesn't
recognize the "UnsynchronizedOverridesSynchronized" as a valid value for
the @SuppressWarnings annotation [2].

[1] https://errorprone.info/bugpattern/UnsynchronizedOverridesSynchronized
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=392045

Change-Id: I3e798b448211f1363729091f72fb0ef6a873e599
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java