]> source.dussan.org Git - nextcloud-server.git/commit
Return correct loginname in credentials,
authorLionel Elie Mamane <lionel@mamane.lu>
Sat, 20 Jun 2020 09:21:41 +0000 (11:21 +0200)
committerMorris Jobke <hey@morrisjobke.de>
Thu, 20 Aug 2020 14:02:22 +0000 (16:02 +0200)
commitac8b40b8b12d4bf85bdd6b7ab038f0605c8651d9
treec1ea1568445cd6168c571721a7e362f60b168833
parent03603db486debbb31dfa05486f3b10338a28b50c
Return correct loginname in credentials,

even when token is invalid or has no password.

Returning the uid as loginname is wrong, and leads to problems when
these differ. E.g. the getapppassword API was creating app token with
the uid as loginname. In a scenario with external authentication (such
as LDAP), these tokens were then invalidated next time their underlying
password was checked, and systematically ceased to function.

Co-authored-by: kesselb <mail@danielkesselberg.de>
for: switch to consistent camelCase

Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
lib/private/Authentication/LoginCredentials/Store.php
lib/private/Server.php
lib/private/User/Session.php
lib/public/User/Events/PostLoginEvent.php